Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings FFLAGS breaks numpy.distutils Fortran compilation #163

Open
pv opened this issue May 5, 2018 · 2 comments
Open

Settings FFLAGS breaks numpy.distutils Fortran compilation #163

pv opened this issue May 5, 2018 · 2 comments

Comments

@pv
Copy link

pv commented May 5, 2018

The following part in multibuild sets the FFLAGS etc. environment variables:
https://github.com/matthew-brett/multibuild/blob/devel/configure_build.sh#L32-L34

However, for numpy.distutils an environment variable with empty value is not the same thing as unset environment variable. Instead, the value of the environment variable fully overrides the default value.

In this case, setting empty FFLAGS removes -fPIC from numpy.distutils fortran compilation.
Moreover, numpy.distutils does not use the contents of FFLAGS in constructing the linker command line, so adding -Wl,-strip-all to FFLAGS has no effect --- numpy.distutils appears to only look at the contents of the LDFLAGS variable, cf MacPython/scipy-wheels#31

@MarkWieczorek
Copy link

I'm having the same problem. -fPIC is being removed from the compiler options, causing the build to fail.

SHTOOLS/SHTOOLS#149

@matthew-brett
Copy link
Collaborator

@pv - what do you think we should do about the FFLAGS?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants