Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad SSL handshake should close client connection #39

Open
hyena opened this issue Mar 18, 2019 · 1 comment
Open

Bad SSL handshake should close client connection #39

hyena opened this issue Mar 18, 2019 · 1 comment
Assignees

Comments

@hyena
Copy link
Collaborator

hyena commented Mar 18, 2019

This is one for me. Testing by connecting to Fuzzball without ssl on the ssl port and typing garbage will close the socket on the user's side. Presently mutgos does not. This issue is to fix this to be sure my code is not leaking sockets.

@zelerin
Copy link
Member

zelerin commented Mar 19, 2019

That is a little tricky with boost, since they use smart pointers and such. You'll likely need to use valgrind to confirm it's working as expected. Sometimes I've seen the last socket hang around even after disconnect... so you may need to connect multiple times and confirm it's releasing them. I don't expect it to be too hard to fix, though, and is likely just a couple of lines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants