OGNL source code not included ?

[WestFarmer]

when debugging ognl related bug, where to get source code of org.apache.ibatis.ognl ?

[WestFarmer]

I see this in pom.xml, but the source jar download by my IDE still have no relocated source code of OGNL, something must be wrong.

<!-- We are manipulating the phase to run before package so shading will be used for building source jar
         and further turning off attach here as shading will do that.  This is required for ognl and javassist
         for IDE's usage -->

[harawata]

I did a quick check and...

• Locally built sources JAR (./mvnw package -Prelease) contains all sources, it seems.
• In the snapshots on Sonatype, only the shaded dependencies' sources (i.e. OGNL and Javassist) are included.
  https://oss.sonatype.org/content/repositories/snapshots/org/mybatis/mybatis/
• In the releases on the central, OGNL and Javassist sources are missing.

If someone knows a solution, please comment.

Cc: @hazendaz

[hazendaz]

@harawata Thanks for investigating, looks like a bit of a mess. I'll take a look at this.

[hazendaz]

The issue was addressed per #3045 back in late December but has not shown up on a release yet. The next release will have this resolved on releases.

The issue with sonatype I'm fixing to run -Prelease to pick up other cyles so it shows up on snapshots as well as we only run deploy which doesn't kick off the release profile that was added to fix the issue in December.

[hazendaz]

I did a quick check and...

* Locally built sources JAR (`./mvnw package -Prelease`) contains all sources, it seems. --> Was fixed in December 2023.

* In the snapshots on Sonatype, only the shaded dependencies' sources (i.e. OGNL and Javassist) are included.
  https://oss.sonatype.org/content/repositories/snapshots/org/mybatis/mybatis/ --> Added -Prelease to sonatype to fix 4/1/2024.

* In the releases on the central, OGNL and Javassist sources are missing. --> Correct, was missing from all, it will be there on next release.