Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SensorSHT31.h #551

Open
NickLplus opened this issue May 21, 2022 · 3 comments
Open

SensorSHT31.h #551

NickLplus opened this issue May 21, 2022 · 3 comments
Labels
Projects

Comments

@NickLplus
Copy link

A small one:
SensorSHT31.h reports temperature in ° Fahrenheit even when I_CONFIG is 0 ('Metric').

@user2684 user2684 added the bug label Jun 6, 2022
@user2684 user2684 added this to Triage in v1.9 via automation Jun 6, 2022
@user2684
Copy link
Contributor

user2684 commented Jun 6, 2022

Hi, never seen this behaviour before, will mark it as a bug and try to reproduce it. In case you have logs to share would be great. Thanks

@NickLplus
Copy link
Author

Thank you for looking into it. The line
temperature = nodeManager.celsiusToFahrenheit(temperature);
seems to be executed always, without a check for I_CONFIG value.

@user2684
Copy link
Contributor

Actually the check is inside the function (https://github.com/mysensors/NodeManager/blob/master/nodemanager/Node.cpp#L138). The logs should tell you if I_CONFIG is updated correctly, let's have a look :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
v1.9
  
Triage
Development

No branches or pull requests

2 participants