We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MyData seems to open and re-parse the includesFile and/or excludesFile (if enabled) for every file it finds while walking FolderModels:
The offending open() / readlines() is in MatchesPatterns(). It's called by:
which are called in the os.walk() file loop during FolderModel initialisation.
Worst case: both glob files are re-parsed for every os.walk()-ed file if both useIncludes and useExcludes are true.
Suggestion: check and cache the {in,ex}clude glob files' modification times before the os.walk loop and re-parse them if there's a change.
The text was updated successfully, but these errors were encountered:
No branches or pull requests
MyData seems to open and re-parse the includesFile and/or excludesFile (if enabled) for every file it finds while walking FolderModels:
The offending open() / readlines() is in MatchesPatterns(). It's called by:
which are called in the os.walk() file loop during FolderModel initialisation.
Worst case: both glob files are re-parsed for every os.walk()-ed file if both useIncludes and useExcludes are true.
Suggestion: check and cache the {in,ex}clude glob files' modification times before the os.walk loop and re-parse them if there's a change.
The text was updated successfully, but these errors were encountered: