Google Chrome Test #92 #154
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertmin1
force-pushed
the
chrometest
branch
from
f246429 to
dadd890
Compare
Google Chrome Test namecoin#92
robertmin1
force-pushed
the
chrometest
branch
from
dadd890 to
da545d9
Compare
|
Given that we already have tests for Chromium, I'm worried about the code duplication that this PR introduces. I think I'd prefer that Google Chrome be handled via a Cirrus matrix rather than a separate task item, so that we can reuse most of the Chromium tests for Chrome without code duplication. See the IceCat and LibreWolf tests for some potential inspiration. |
|
Implemented it in a matrix, preventing code duplication. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a Google Chrome Test
Fix #92