{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":48567390,"defaultBranch":"master","name":"ksmbd-tools","ownerLogin":"namjaejeon","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2015-12-25T05:12:40.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/13989893?v=4","public":true,"private":false,"isOrgOwned":false},"refInfo":{"name":"","listCacheKey":"v0:1711347273.0","currentOid":""},"activityList":{"items":[{"before":"f5173cbf643907e0d5e9d6da88b9a081b097fe84","after":"78bef66b7c653f353f82b96a330945f4fc198db6","ref":"refs/heads/master","pushedAt":"2024-09-15T07:50:43.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"namjaejeon","name":"Namjae Jeon","path":"/namjaejeon","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/13989893?s=80&v=4"},"commit":{"message":"ksmbd-tools: don't inherit global 'veto files' parameter to $ipc share\n\n$ipc share doesn't have payload size of veto files. but share has\nveto_list_sz. ksmbd validate veto_list_sz and payload_sz of ipc request\nto avoid reading out of buffer. This patch don't inherit 'veto files'\nparameter that is declared in global section to $ipc share.\n\nSigned-off-by: Namjae Jeon ","shortMessageHtmlLink":"ksmbd-tools: don't inherit global 'veto files' parameter to $ipc share"}},{"before":"f374561990f85fbccd9f906eba7b9477935e6054","after":"f5173cbf643907e0d5e9d6da88b9a081b097fe84","ref":"refs/heads/master","pushedAt":"2024-09-14T04:29:48.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"namjaejeon","name":"Namjae Jeon","path":"/namjaejeon","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/13989893?s=80&v=4"},"commit":{"message":"ksmbd-tools: prevent recursive @group lookup\n\nA non-standards-compliant login name that begins with an @ sign may\nbe used e.g. by giving --badname to useradd(8). Users with such names\ncannot be used in parameters that take a user list, since the leading\n@ sign is reserved for @group, but we still allow such names elsewhere.\nIf an @group lookup resolves into such a name, treat it now as a user\nname rather than another @group. The bug fixed here was introduced in\ncommit cb106ed (\"ksmbd-tools: introduce add_users_map() and stub\nadd_hosts_map()\").\n\nSigned-off-by: Atte Heikkilä \nSigned-off-by: Namjae Jeon ","shortMessageHtmlLink":"ksmbd-tools: prevent recursive @group lookup"}},{"before":"549ec0eb3728a8c6852b80c3eb9303e20b7c1d52","after":"f374561990f85fbccd9f906eba7b9477935e6054","ref":"refs/heads/master","pushedAt":"2024-09-11T07:18:03.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"namjaejeon","name":"Namjae Jeon","path":"/namjaejeon","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/13989893?s=80&v=4"},"commit":{"message":"ksmbd-tools: add users who have @group as their primary group\n\nIt was reported that Samba supports a use case where @group is treated as a\nprimary group. Rather than only adding users who have it as a supplementary\ngroup, we now also add users who have the group as their primary group. Since\nPOSIX does not offer a good way of doing this, we iterate through the system\npassword database and look for users with the matching GID.\n\nSigned-off-by: Atte Heikkilä \nSigned-off-by: Namjae Jeon ","shortMessageHtmlLink":"ksmbd-tools: add users who have @group as their primary group"}},{"before":"d1e8af1a8050b63e622ab1ea05098a8b603b4f8e","after":"549ec0eb3728a8c6852b80c3eb9303e20b7c1d52","ref":"refs/heads/master","pushedAt":"2024-06-27T23:16:18.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"namjaejeon","name":"Namjae Jeon","path":"/namjaejeon","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/13989893?s=80&v=4"},"commit":{"message":"ksmbd-tools: fix prompting when built against musl libc\n\nThe output stream flushing schemes of GNU libc and musl libc differ,\nresulting in addshare and adduser prompting incorrectly when built\nagainst the latter. Fix this by flushing explicitly with fflush(3).\n\nSigned-off-by: Atte Heikkilä \nSigned-off-by: Namjae Jeon ","shortMessageHtmlLink":"ksmbd-tools: fix prompting when built against musl libc"}},{"before":"e4662a0ae1a36847be84a9d84afd7399e5c95ccb","after":"d1e8af1a8050b63e622ab1ea05098a8b603b4f8e","ref":"refs/heads/master","pushedAt":"2024-06-21T14:00:12.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"namjaejeon","name":"Namjae Jeon","path":"/namjaejeon","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/13989893?s=80&v=4"},"commit":{"message":"ksmbd-tools: make KSMBD_SHARE_FLAG_WRITEABLE and KSMBD_SHARE_FLAG_READONLY mutually exclusive\n\nMake KSMBD_SHARE_FLAG_WRITEABLE and KSMBD_SHARE_FLAG_READONLY mutually\nexclusive.\n\nSigned-off-by: Namjae Jeon ","shortMessageHtmlLink":"ksmbd-tools: make KSMBD_SHARE_FLAG_WRITEABLE and KSMBD_SHARE_FLAG_REA…"}},{"before":"cda9a352dc3323f47f3dff3d04416023a6a3f457","after":"e4662a0ae1a36847be84a9d84afd7399e5c95ccb","ref":"refs/heads/master","pushedAt":"2024-04-05T23:19:26.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"namjaejeon","name":"Namjae Jeon","path":"/namjaejeon","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/13989893?s=80&v=4"},"commit":{"message":"ksmbd-tools: release 3.5.2 version\n\nMajor changes are:\n - Add durable handles parameter to ksmbd.conf.\n - Add payload_sz in ksmbd_share_config_response to validate ipc\n response.\n - Fix UAF and cleanups.\n\nSigned-off-by: Namjae Jeon ","shortMessageHtmlLink":"ksmbd-tools: release 3.5.2 version"}},{"before":"756e7656cb228b3e887b34938681c3ee06044e7b","after":"cda9a352dc3323f47f3dff3d04416023a6a3f457","ref":"refs/heads/master","pushedAt":"2024-03-29T23:24:33.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"namjaejeon","name":"Namjae Jeon","path":"/namjaejeon","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/13989893?s=80&v=4"},"commit":{"message":"ksmbd: add payload_sz in ksmbd_share_config_response\n\nIf installing malicious ksmbd-tools, ksmbd.mountd can return invalid ipc\nresponse to ksmbd kernel server. ksmbd should validate payload size of\nipc response from ksmbd.mountd to avoid memory overrun or\nslab-out-of-bounds. This patch set payload_sz of payload_sz in\nksmbd_share_config_response to help ksmbd validate payload size of\nKSMBD_EVENT_SHARE_CONFIG_RESPONSE ipc response\n\nSigned-off-by: Namjae Jeon ","shortMessageHtmlLink":"ksmbd: add payload_sz in ksmbd_share_config_response"}},{"before":"cb6f8cb0bb2e6413c7470b88dc67ba4b160f43ab","after":"756e7656cb228b3e887b34938681c3ee06044e7b","ref":"refs/heads/master","pushedAt":"2024-03-29T15:02:29.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"namjaejeon","name":"Namjae Jeon","path":"/namjaejeon","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/13989893?s=80&v=4"},"commit":{"message":"ksmbd: add payload_sz in ksmbd_share_config_response\n\nksmbd server should validate KSMBD_EVENT_SHARE_CONFIG_RESPONSE ipc\nresponse using payload_sz. malicious ksmbd-tools can return invalid value\nto veto_list_sz of ksmbd_share_config_response to ksmbd server and\nksmbd server can access invalid address.\n\nSigned-off-by: Namjae Jeon ","shortMessageHtmlLink":"ksmbd: add payload_sz in ksmbd_share_config_response"}},{"before":"7448e6db08f69949406328af682b1d4f07de9549","after":"cb6f8cb0bb2e6413c7470b88dc67ba4b160f43ab","ref":"refs/heads/master","pushedAt":"2024-03-27T23:18:56.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"namjaejeon","name":"Namjae Jeon","path":"/namjaejeon","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/13989893?s=80&v=4"},"commit":{"message":"ksmbd-tools: add support for durable handles\n\nAs durable handles is supported in ksmbd kernel server, Add durable\nhandles parameter in ksmbd-tools. I would like to make it default\ndisable till it is stable.\n\nSigned-off-by: Namjae Jeon ","shortMessageHtmlLink":"ksmbd-tools: add support for durable handles"}},{"before":"a5f07fa170bbe7a7d8be2abb8cd26d9580a37bdf","after":"7448e6db08f69949406328af682b1d4f07de9549","ref":"refs/heads/master","pushedAt":"2024-03-26T11:12:26.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"namjaejeon","name":"Namjae Jeon","path":"/namjaejeon","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/13989893?s=80&v=4"},"commit":{"message":"ksmbd-tools: add support for durable handles\n\nAs durable handles is supported in ksmbd kernel server, Add durable\nhandles parameter in ksmbd-tools. I would like to make it default\ndisable till it is stable.\n\nSigned-off-by: Namjae Jeon ","shortMessageHtmlLink":"ksmbd-tools: add support for durable handles"}},{"before":"65c14cf7cc85fd8780aaffd40821d909c28ec14e","after":"930b0e6da6415b39bb6504069bb92593ce8beba9","ref":"refs/heads/dh","pushedAt":"2024-03-25T06:28:25.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"namjaejeon","name":"Namjae Jeon","path":"/namjaejeon","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/13989893?s=80&v=4"},"commit":{"message":"ksmbd-tools: add support for durable handles\n\nAs durable handles is supported in ksmbd kernel server, Add durable\nhandles parameter in ksmbd-tools. I would like to make it default\ndisable till it is stable.\n\nSigned-off-by: Namjae Jeon ","shortMessageHtmlLink":"ksmbd-tools: add support for durable handles"}},{"before":"a5f07fa170bbe7a7d8be2abb8cd26d9580a37bdf","after":"65c14cf7cc85fd8780aaffd40821d909c28ec14e","ref":"refs/heads/dh","pushedAt":"2024-03-25T06:16:17.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"namjaejeon","name":"Namjae Jeon","path":"/namjaejeon","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/13989893?s=80&v=4"},"commit":{"message":"ksmbd-tools: add support for durable handles\n\nAs durable handles is supported in ksmbd kernel server, Add durable\nhandles parameter in ksmbd-tools. I would like to make it default\ndisable till it is stable.\n\nSigned-off-by: Namjae Jeon ","shortMessageHtmlLink":"ksmbd-tools: add support for durable handles"}},{"before":null,"after":"a5f07fa170bbe7a7d8be2abb8cd26d9580a37bdf","ref":"refs/heads/dh","pushedAt":"2024-03-25T06:14:33.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"namjaejeon","name":"Namjae Jeon","path":"/namjaejeon","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/13989893?s=80&v=4"},"commit":{"message":"ksmbd-tools: fix GCC parentheses warnings\n\nGCC suggests clarifying order of evaluation.\n\nSigned-off-by: Rosen Penev \nSigned-off-by: Namjae Jeon ","shortMessageHtmlLink":"ksmbd-tools: fix GCC parentheses warnings"}},{"before":"6521d2db6c006d4c8cd7cc4ae521e4a5329fca54","after":"a5f07fa170bbe7a7d8be2abb8cd26d9580a37bdf","ref":"refs/heads/master","pushedAt":"2024-01-13T14:32:58.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"namjaejeon","name":"Namjae Jeon","path":"/namjaejeon","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/13989893?s=80&v=4"},"commit":{"message":"ksmbd-tools: fix GCC parentheses warnings\n\nGCC suggests clarifying order of evaluation.\n\nSigned-off-by: Rosen Penev \nSigned-off-by: Namjae Jeon ","shortMessageHtmlLink":"ksmbd-tools: fix GCC parentheses warnings"}},{"before":"79e1d37128a2b8939f0a64fa04c3f3c8d6d19e3a","after":"6521d2db6c006d4c8cd7cc4ae521e4a5329fca54","ref":"refs/heads/master","pushedAt":"2024-01-13T06:07:42.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"namjaejeon","name":"Namjae Jeon","path":"/namjaejeon","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/13989893?s=80&v=4"},"commit":{"message":"ksmbd-tools: fix GCC parentheses warnings\n\nGCC suggests clarifying order of evaluation.\n\nSigned-off-by: Rosen Penev \nSigned-off-by: Namjae Jeon ","shortMessageHtmlLink":"ksmbd-tools: fix GCC parentheses warnings"}},{"before":"7b3e975528cb9095114cd7713fee8dcb3e5229d6","after":"79e1d37128a2b8939f0a64fa04c3f3c8d6d19e3a","ref":"refs/heads/master","pushedAt":"2024-01-13T06:06:05.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"namjaejeon","name":"Namjae Jeon","path":"/namjaejeon","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/13989893?s=80&v=4"},"commit":{"message":"fix GCC parentheses warnings\n\nGCC suggests clarifying order of evaluation.\n\nSigned-off-by: Rosen Penev \nSigned-off-by: Namjae Jeon ","shortMessageHtmlLink":"fix GCC parentheses warnings"}},{"before":"8807bd2113905e1c919e7b9c039604798dd078c6","after":"7b3e975528cb9095114cd7713fee8dcb3e5229d6","ref":"refs/heads/master","pushedAt":"2023-11-12T12:33:02.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"namjaejeon","name":"Namjae Jeon","path":"/namjaejeon","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/13989893?s=80&v=4"},"commit":{"message":"ksmbd-tools: eliminate a use-after-free\n\nEliminate a use-after-free.\n\nSigned-off-by: Robert Morris \nSigned-off-by: Namjae Jeon ","shortMessageHtmlLink":"ksmbd-tools: eliminate a use-after-free"}},{"before":"f68fbdfc98caf2c81c27e2e52da121948b435185","after":"8807bd2113905e1c919e7b9c039604798dd078c6","ref":"refs/heads/master","pushedAt":"2023-11-09T04:16:00.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"namjaejeon","name":"Namjae Jeon","path":"/namjaejeon","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/13989893?s=80&v=4"},"commit":{"message":"ksmbd: release 3.5.1 version\n\nMajor changes are:\n - Fix worker_init_sa_handler return type.\n - Don't add global default `read only = yes'.\n Shares are still read-only by default.\n\nSigned-off-by: Namjae Jeon ","shortMessageHtmlLink":"ksmbd: release 3.5.1 version"}},{"before":"8806acc0e6b2b18669b0ea6aa29d07eb92cbae2e","after":"f68fbdfc98caf2c81c27e2e52da121948b435185","ref":"refs/heads/master","pushedAt":"2023-11-09T04:07:42.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"namjaejeon","name":"Namjae Jeon","path":"/namjaejeon","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/13989893?s=80&v=4"},"commit":{"message":"ksmbd-tools: don't add global default `read only = yes'\n\nSince share parameters are applied in the non-descript hash table\niteration order, a share parameter should never undo the effect of an\nanother. For example, `force user' checks `share->force_gid' such that\nit doesn't undo `force group' applied earlier. However, `read only'\ndoes not follow this convention since it may undo `writeable' (and so\nmay its aliases). Since the hash table iteration order is non-descript,\nthis means that a share with `read only = yes' and `writeable = yes'\nmay or may not allow read-write access. With the 3.5.0 release, due to\nthe default global `read only = yes' added in commit 54d2a02, this\neffect is always in play for shares that give `writeable = yes' (or\nits aliases) instead of `read only = no'. Fix this by not adding\nglobal default `read only = yes'.\n\nNote that not setting `KSMBD_SHARE_FLAG_READONLY' for initial shares is\nfine as it is only used to set `KSMBD_TREE_CONN_FLAG_READ_ONLY' which\nitself is unused (and was broken until commit 3f88fbe).\n\nNote also that the use of the IPC$ share is guarded by checking for\n`KSMBD_SHARE_FLAG_PIPE'. So if it's given `KSMBD_SHARE_FLAG_WRITEABLE'\nthrough the global section or a user-defined section, the code paths\nfor its use should not change.\n\nSigned-off-by: Atte Heikkilä \nSigned-off-by: Namjae Jeon ","shortMessageHtmlLink":"ksmbd-tools: don't add global default `read only = yes'"}},{"before":"c4f35c75fc19e2bf42b50f4b2e0e53537017a80d","after":"8806acc0e6b2b18669b0ea6aa29d07eb92cbae2e","ref":"refs/heads/master","pushedAt":"2023-10-31T23:24:23.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"namjaejeon","name":"Namjae Jeon","path":"/namjaejeon","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/13989893?s=80&v=4"},"commit":{"message":"ksmbd-tools: fix worker_init_sa_handler return type\n\nThe function doesn't return any errors, so switch it to void to silence\ncompiler warnings such as:\n mountd.c: In function 'worker_init_sa_handler':\n mountd.c:114:1: error: no return statement in function returning\n\t\t non-void [-Werror=return-type]\n 114 | }\n | ^\n\nSigned-off-by: David Disseldorp \nSigned-off-by: Namjae Jeon ","shortMessageHtmlLink":"ksmbd-tools: fix worker_init_sa_handler return type"}},{"before":"d2f0b56e3a7bedca758b89bd57cdbaaba4e0bb66","after":"c4f35c75fc19e2bf42b50f4b2e0e53537017a80d","ref":"refs/heads/master","pushedAt":"2023-10-30T00:19:42.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"namjaejeon","name":"Namjae Jeon","path":"/namjaejeon","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/13989893?s=80&v=4"},"commit":{"message":"ksmbd-tools: release 3.5.0 version\n\nMajor changes are:\n - Fix potencial NULL deference errors.\n - Improved and cleaned up incorrect Glib library usage.\n - Fix memleak and several bugs.\n - Replace std functions with glib ones.\n - update manpages.\n - Improve the validation of ksmbd-tools's files(subauth, pwddb, conf).\n - Increase the minimum glib version(2.40 -> 2.44)\n - Several clean-ups.\n - Add --list option to ksmbd.control.\n\nSigned-off-by: Namjae Jeon ","shortMessageHtmlLink":"ksmbd-tools: release 3.5.0 version"}},{"before":"a74c97761c42883d387dc218bbdad56a9c1a4353","after":"d2f0b56e3a7bedca758b89bd57cdbaaba4e0bb66","ref":"refs/heads/master","pushedAt":"2023-10-26T22:00:12.000Z","pushType":"push","commitsCount":4,"pusher":{"login":"namjaejeon","name":"Namjae Jeon","path":"/namjaejeon","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/13989893?s=80&v=4"},"commit":{"message":"ksmbd-tools: do full smbconf parse on ENOENT in adduser/addshare\n\nEven if the smbconf file does not exist, we're still interested in the\n`guest account' global parameter in adduser. In addshare the same would\nbe true for the `root directory' global parameter if it had a default\nvalue. Do full smbconf parse even on ENOENT. Although now unnecessary,\nadd a check to prevent NULL deref of `global_conf.guest_account' in\n__is_transient_user().\n\nSigned-off-by: Atte Heikkilä \nSigned-off-by: Namjae Jeon ","shortMessageHtmlLink":"ksmbd-tools: do full smbconf parse on ENOENT in adduser/addshare"}},{"before":"1cb30972d1c8edfe0ee9844547abfc9267be07b0","after":"a74c97761c42883d387dc218bbdad56a9c1a4353","ref":"refs/heads/master","pushedAt":"2023-10-18T14:37:36.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"namjaejeon","name":"Namjae Jeon","path":"/namjaejeon","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/13989893?s=80&v=4"},"commit":{"message":"ksmbd-tools: fix memleak in rpc lsarpc\n\nFix memleak in rpc lsarpc.\n\nSigned-off-by: Namjae Jeon ","shortMessageHtmlLink":"ksmbd-tools: fix memleak in rpc lsarpc"}},{"before":"fb5e7a91b6eca7e40d2df0aeb7283351d848d2c4","after":"1cb30972d1c8edfe0ee9844547abfc9267be07b0","ref":"refs/heads/master","pushedAt":"2023-10-18T14:10:01.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"namjaejeon","name":"Namjae Jeon","path":"/namjaejeon","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/13989893?s=80&v=4"},"commit":{"message":"ksmbd-tools: fix memleak in rpc samr\n\nAtte reported memleak that found using valgrind.\n\n==103365== 1,800 bytes in 100 blocks are definitely lost in loss record 29 of 32\n==103365== at 0x4841848: malloc (vg_replace_malloc.c:431)\n==103365== by 0x48E9502: g_malloc (gmem.c:130)\n==103365== by 0x48BE53C: g_convert_with_iconv (gconvert.c:421)\n==103365== by 0x48BE831: g_convert (gconvert.c:587)\n==103365== by 0x112313: ksmbd_gconvert (tools.c:191)\n==103365== by 0x11921D: ndr_read_vstring (rpc.c:547)\n==103365== by 0x1192F4: ndr_read_uniq_vstring_ptr (rpc.c:579)\n==103365== by 0x11C4C0: samr_lookup_domain_invoke (rpc_samr.c:229)\n==103365== by 0x11C4C0: samr_invoke (rpc_samr.c:888)\n==103365== by 0x11C4C0: rpc_samr_write_request (rpc_samr.c:1005)\n==103365== by 0x11A471: rpc_ioctl_request (rpc.c:1240)\n==103365== by 0x1179A5: rpc_request (worker.c:248)\n==103365== by 0x1179A5: worker_pool_fn (worker.c:295)\n==103365== by 0x4916CB2: g_thread_pool_thread_proxy.lto_priv.0 (gthreadpool.c:350)\n==103365== by 0x4913CD4: g_thread_proxy (gthread.c:831)\n==103365==\n==103365== 8,400 bytes in 300 blocks are definitely lost in loss record 30 of 32\n==103365== at 0x4841848: malloc (vg_replace_malloc.c:431)\n==103365== by 0x48E9502: g_malloc (gmem.c:130)\n==103365== by 0x48BE53C: g_convert_with_iconv (gconvert.c:421)\n==103365== by 0x48BE831: g_convert (gconvert.c:587)\n==103365== by 0x112313: ksmbd_gconvert (tools.c:191)\n==103365== by 0x11921D: ndr_read_vstring (rpc.c:547)\n==103365== by 0x1192F4: ndr_read_uniq_vstring_ptr (rpc.c:579)\n==103365== by 0x11C522: samr_connect5_invoke (rpc_samr.c:87)\n==103365== by 0x11C522: samr_invoke (rpc_samr.c:882)\n==103365== by 0x11C522: rpc_samr_write_request (rpc_samr.c:1005)\n==103365== by 0x11A471: rpc_ioctl_request (rpc.c:1240)\n==103365== by 0x1179A5: rpc_request (worker.c:248)\n==103365== by 0x1179A5: worker_pool_fn (worker.c:295)\n==103365== by 0x4916CB2: g_thread_pool_thread_proxy.lto_priv.0 (gthreadpool.c:350)\n==103365== by 0x4913CD4: g_thread_proxy (gthread.c:831)\n\nReported-by: Atte Heikkilä \nSigned-off-by: Namjae Jeon ","shortMessageHtmlLink":"ksmbd-tools: fix memleak in rpc samr"}},{"before":"0eaca43404b2ab8c0cd2dfbebf0b597cfaa837bd","after":"fb5e7a91b6eca7e40d2df0aeb7283351d848d2c4","ref":"refs/heads/master","pushedAt":"2023-10-16T12:59:05.000Z","pushType":"push","commitsCount":12,"pusher":{"login":"namjaejeon","name":"Namjae Jeon","path":"/namjaejeon","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/13989893?s=80&v=4"},"commit":{"message":"Revert \"ksmbd-tools: lookup both guest accounts on tree connect\"\n\nThis reverts commit 12cfe708346b0de14f116edc2f449e79267d061a.\n\nReverting commit 0b87a71 has made this commit obsolete as the guest\naccount refcount bug no longer occurs.\n\nSigned-off-by: Atte Heikkilä \nSigned-off-by: Namjae Jeon ","shortMessageHtmlLink":"Revert \"ksmbd-tools: lookup both guest accounts on tree connect\""}},{"before":"6b70b5af9e6b065320a7222ead3352c0d67b7d04","after":"0eaca43404b2ab8c0cd2dfbebf0b597cfaa837bd","ref":"refs/heads/master","pushedAt":"2023-10-06T00:15:37.000Z","pushType":"push","commitsCount":4,"pusher":{"login":"namjaejeon","name":"Namjae Jeon","path":"/namjaejeon","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/13989893?s=80&v=4"},"commit":{"message":"ksmbd-tools: don't use fixed printf format for subauth file write\n\nDon't hardcode the number of subauths in the printf format.\n\nSigned-off-by: Atte Heikkilä \nSigned-off-by: Namjae Jeon ","shortMessageHtmlLink":"ksmbd-tools: don't use fixed printf format for subauth file write"}},{"before":"481cfc65e57ca7a3e18fffba900766a67c2c459b","after":"6b70b5af9e6b065320a7222ead3352c0d67b7d04","ref":"refs/heads/master","pushedAt":"2023-09-23T10:30:28.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"namjaejeon","name":"Namjae Jeon","path":"/namjaejeon","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/13989893?s=80&v=4"},"commit":{"message":"ksmbd-tools: remove list_hosts_callback()\n\nAfter commit 9d0d35f, if KSMBD_SHARE_CONF_IS_BROKEN() had not disabled\nthe add_hosts_map() codepaths, list_hosts_callback() would free already\nfreed memory.\n\nSigned-off-by: Atte Heikkilä \nSigned-off-by: Namjae Jeon ","shortMessageHtmlLink":"ksmbd-tools: remove list_hosts_callback()"}},{"before":"98c5d20f3c7e60ff58918edaf2e232e3d862138e","after":"481cfc65e57ca7a3e18fffba900766a67c2c459b","ref":"refs/heads/master","pushedAt":"2023-09-19T23:46:04.000Z","pushType":"push","commitsCount":5,"pusher":{"login":"namjaejeon","name":"Namjae Jeon","path":"/namjaejeon","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/13989893?s=80&v=4"},"commit":{"message":"ksmbd-tools: ignore extra lines in subauth file\n\nOnly the first line is of interest in the subauth file.\n\nSigned-off-by: Atte Heikkilä \nSigned-off-by: Namjae Jeon ","shortMessageHtmlLink":"ksmbd-tools: ignore extra lines in subauth file"}},{"before":"e012ed8d65794490357138c95e8ba2b4231c221d","after":"98c5d20f3c7e60ff58918edaf2e232e3d862138e","ref":"refs/heads/master","pushedAt":"2023-09-17T13:44:08.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"namjaejeon","name":"Namjae Jeon","path":"/namjaejeon","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/13989893?s=80&v=4"},"commit":{"message":"ksmbd-tools: tweak printf format for byte prints in config parser\n\nThe `2' preceding `X' should be precision and not minimum field width.\nAlso, `char' is signed on many platforms and we do not want sign\nextension to appear when the argument gets promoted to `int'.\n\nSigned-off-by: Atte Heikkilä \nSigned-off-by: Namjae Jeon ","shortMessageHtmlLink":"ksmbd-tools: tweak printf format for byte prints in config parser"}},{"before":"6f2abc2378c4bf0ebaa189580308de5f25a5e990","after":"e012ed8d65794490357138c95e8ba2b4231c221d","ref":"refs/heads/master","pushedAt":"2023-09-11T11:33:23.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"namjaejeon","name":"Namjae Jeon","path":"/namjaejeon","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/13989893?s=80&v=4"},"commit":{"message":"ksmbd-tools: add missing dash escapes to man pages\n\nWithout the escape, the character appears as a hyphen and\nmay be difficult to read on some output devices.\n\nSigned-off-by: Atte Heikkilä \nSigned-off-by: Namjae Jeon ","shortMessageHtmlLink":"ksmbd-tools: add missing dash escapes to man pages"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"Y3Vyc29yOnYyOpK7MjAyNC0wOS0xNVQwNzo1MDo0My4wMDAwMDBazwAAAAS2lNS9","startCursor":"Y3Vyc29yOnYyOpK7MjAyNC0wOS0xNVQwNzo1MDo0My4wMDAwMDBazwAAAAS2lNS9","endCursor":"Y3Vyc29yOnYyOpK7MjAyMy0wOS0xMVQxMTozMzoyMy4wMDAwMDBazwAAAAN9yhdp"}},"title":"Activity · namjaejeon/ksmbd-tools"}