From 4d417fddc6454ab4740db5615bba9ef6463feb86 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Thu, 20 Jun 2024 06:34:17 +0000 Subject: [PATCH 1/2] Bump @types/selenium-webdriver from 4.1.22 to 4.1.23 Bumps [@types/selenium-webdriver](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/selenium-webdriver) from 4.1.22 to 4.1.23. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/selenium-webdriver) --- updated-dependencies: - dependency-name: "@types/selenium-webdriver" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] --- package.json | 2 +- yarn.lock | 9 +++++---- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/package.json b/package.json index b036e6fb..5fb8319c 100644 --- a/package.json +++ b/package.json @@ -34,7 +34,7 @@ "devDependencies": { "@types/jest": "^27.4.1", "@types/node": "^20.14.4", - "@types/selenium-webdriver": "^4.1.22", + "@types/selenium-webdriver": "^4.1.23", "@types/semver": "^7.5.8", "@types/yauzl": "^2.10.3", "@vercel/ncc": "^0.38.1", diff --git a/yarn.lock b/yarn.lock index 4c4ba1c7..7c9954ac 100644 --- a/yarn.lock +++ b/yarn.lock @@ -1185,11 +1185,12 @@ resolved "https://registry.yarnpkg.com/@types/prettier/-/prettier-2.4.4.tgz#5d9b63132df54d8909fce1c3f8ca260fdd693e17" integrity sha512-ReVR2rLTV1kvtlWFyuot+d1pkpG2Fw/XKE3PDAdj57rbM97ttSp9JZ2UsP+2EHTylra9cUf6JA7tGwW1INzUrA== -"@types/selenium-webdriver@^4.1.22": - version "4.1.22" - resolved "https://registry.yarnpkg.com/@types/selenium-webdriver/-/selenium-webdriver-4.1.22.tgz#344519b90727eb713e1ce6d2e0198eb0b4f8f316" - integrity sha512-MCL4l7q8dwxejr2Q2NXLyNwHWMPdlWE0Kpn6fFwJtvkJF7PTkG5jkvbH/X1IAAQxgt/L1dA8u2GtDeekvSKvOA== +"@types/selenium-webdriver@^4.1.23": + version "4.1.23" + resolved "https://registry.yarnpkg.com/@types/selenium-webdriver/-/selenium-webdriver-4.1.23.tgz#05a2794927db661f075ab443d5504b679b32f7f7" + integrity sha512-PgreEfCfafYLyTwvJTZvOspCq3JABnS51e+NSFFL5yoiMO7h04lWgLfr10NA7nl/yZbz4m76rBfOOdDfleb7pQ== dependencies: + "@types/node" "*" "@types/ws" "*" "@types/semver@^7.5.8": From d6dce55db66373a0f5b992d11e8ef1eb5c0098eb Mon Sep 17 00:00:00 2001 From: Kentaro Ohkouchi Date: Mon, 24 Jun 2024 00:09:03 +0900 Subject: [PATCH 2/2] Use ts-node Fix error TS1192: Module '"/Users/runner/work/setup-chromedriver/setup-chromedriver/node_modules/@types/selenium-webdriver/http"' has no default export. --- .github/workflows/test.yml | 26 +++++++++++++------------- .github/workflows/windows.yml | 32 ++++++++++++++++---------------- 2 files changed, 29 insertions(+), 29 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 07155708..bd526429 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -47,12 +47,12 @@ jobs: - run: yarn build - run: yarn package - run: yarn test - - run: | - node_modules/.bin/tsc $GITHUB_WORKSPACE/__tests__/chromedriver.ts - # Cannot find chromedriver when using ncc. - # see https://github.com/nanasess/setup-chromedriver/issues/303 - # node_modules/.bin/ncc build $GITHUB_WORKSPACE/__tests__/chromedriver.js -o $GITHUB_WORKSPACE/__tests__ - # rm -rf node_modules + # - run: | + # node_modules/.bin/tsc $GITHUB_WORKSPACE/__tests__/chromedriver.ts + # # Cannot find chromedriver when using ncc. + # # see https://github.com/nanasess/setup-chromedriver/issues/303 + # # node_modules/.bin/ncc build $GITHUB_WORKSPACE/__tests__/chromedriver.js -o $GITHUB_WORKSPACE/__tests__ + # # rm -rf node_modules - if: matrix.chrome_version != 'current' env: CHROME_VERSION: ${{ matrix.chrome_version }} @@ -82,7 +82,7 @@ jobs: export DISPLAY=:99 chromedriver --url-base=/wd/hub & sudo Xvfb -ac :99 -screen 0 1280x1024x24 > /dev/null 2>&1 & # disable headless mode - node $GITHUB_WORKSPACE/__tests__/chromedriver.js + node_modules/.bin/ts-node $GITHUB_WORKSPACE/__tests__/chromedriver.ts test_default_version: runs-on: ${{ matrix.os }} @@ -111,11 +111,11 @@ jobs: - run: yarn build - run: yarn package - run: yarn test - - run: | - node_modules/.bin/tsc $GITHUB_WORKSPACE/__tests__/chromedriver.ts - # Cannot find chromedriver when using ncc. - # see https://github.com/nanasess/setup-chromedriver/issues/303 - # node_modules/.bin/ncc build $GITHUB_WORKSPACE/__tests__/chromedriver.js -o $GITHUB_WORKSPACE/__tests__ + # - run: | + # node_modules/.bin/tsc $GITHUB_WORKSPACE/__tests__/chromedriver.ts + # # Cannot find chromedriver when using ncc. + # # see https://github.com/nanasess/setup-chromedriver/issues/303 + # # node_modules/.bin/ncc build $GITHUB_WORKSPACE/__tests__/chromedriver.js -o $GITHUB_WORKSPACE/__tests__ # rm -rf node_modules - uses: ./ if: matrix.branch == 'now' @@ -127,4 +127,4 @@ jobs: export DISPLAY=:99 chromedriver --url-base=/wd/hub & sudo Xvfb -ac :99 -screen 0 1280x1024x24 > /dev/null 2>&1 & # disable headless mode - node $GITHUB_WORKSPACE/__tests__/chromedriver.js + node_modules/.bin/ts-node $GITHUB_WORKSPACE/__tests__/chromedriver.ts diff --git a/.github/workflows/windows.yml b/.github/workflows/windows.yml index 43b3ec27..ac48678b 100644 --- a/.github/workflows/windows.yml +++ b/.github/workflows/windows.yml @@ -33,13 +33,13 @@ jobs: - run: yarn build - run: yarn package - run: yarn test - - run: | - node_modules/.bin/tsc $GITHUB_WORKSPACE/__tests__/chromedriver.ts - # Cannot find chromedriver when using ncc. - # see https://github.com/nanasess/setup-chromedriver/issues/303 - # node_modules/.bin/ncc build $GITHUB_WORKSPACE/__tests__/chromedriver.js -o $GITHUB_WORKSPACE/__tests__ - # rm -rf node_modules - shell: bash + # - run: | + # node_modules/.bin/tsc $GITHUB_WORKSPACE/__tests__/chromedriver.ts + # # Cannot find chromedriver when using ncc. + # # see https://github.com/nanasess/setup-chromedriver/issues/303 + # # node_modules/.bin/ncc build $GITHUB_WORKSPACE/__tests__/chromedriver.js -o $GITHUB_WORKSPACE/__tests__ + # # rm -rf node_modules + # shell: bash - shell: pwsh run: | $chrome_fullversion = (Get-Item $Env:CHROMEAPP).VersionInfo.FileVersion @@ -65,7 +65,7 @@ jobs: - name: setup run: | chromedriver --url-base=/wd/hub & - node "$Env:GITHUB_WORKSPACE\__tests__\chromedriver.js" + node_modules\.bin\ts-node "$Env:GITHUB_WORKSPACE\__tests__\chromedriver.ts" test_default_version: runs-on: ${{ matrix.os }} @@ -84,13 +84,13 @@ jobs: - run: yarn build - run: yarn package - run: yarn test - - run: | - node_modules/.bin/tsc $GITHUB_WORKSPACE/__tests__/chromedriver.ts - # Cannot find chromedriver when using ncc. - # see https://github.com/nanasess/setup-chromedriver/issues/303 - # node_modules/.bin/ncc build $GITHUB_WORKSPACE/__tests__/chromedriver.js -o $GITHUB_WORKSPACE/__tests__ - # rm -rf node_modules - shell: bash + # - run: | + # node_modules/.bin/tsc $GITHUB_WORKSPACE/__tests__/chromedriver.ts + # # Cannot find chromedriver when using ncc. + # # see https://github.com/nanasess/setup-chromedriver/issues/303 + # # node_modules/.bin/ncc build $GITHUB_WORKSPACE/__tests__/chromedriver.js -o $GITHUB_WORKSPACE/__tests__ + # # rm -rf node_modules + # shell: bash - uses: ./ if: matrix.branch == 'now' - uses: nanasess/setup-chromedriver@master @@ -98,4 +98,4 @@ jobs: - name: setup run: | chromedriver --url-base=/wd/hub & - node "$Env:GITHUB_WORKSPACE\__tests__\chromedriver.js" + node_modules\.bin\ts-node "$Env:GITHUB_WORKSPACE\__tests__\chromedriver.ts"