Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in enterprise_extensions.sampler.JumpProposal.fe_jump? #207

Open
abhisrkckl opened this issue Apr 10, 2023 · 0 comments
Open

Bug in enterprise_extensions.sampler.JumpProposal.fe_jump? #207

abhisrkckl opened this issue Apr 10, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@abhisrkckl
Copy link

This function computes the Prior contribution to the Hastings factor as follows:

        hastings_extra_factor = self.params[self.pimap['log10_h']].get_pdf(log10_h_old)
        hastings_extra_factor *= 1/self.params[self.pimap['log10_h']].get_pdf(log10_h)
        hastings_extra_factor = self.params[self.pimap['phase0']].get_pdf(phase0_old)
        hastings_extra_factor *= 1/self.params[self.pimap['phase0']].get_pdf(phase0)
        hastings_extra_factor = self.params[self.pimap['psi']].get_pdf(psi_old)
        hastings_extra_factor *= 1/self.params[self.pimap['psi']].get_pdf(psi)
        hastings_extra_factor = self.params[self.pimap['cos_inc']].get_pdf(cos_inc_old)
        hastings_extra_factor *= 1/self.params[self.pimap['cos_inc']].get_pdf(cos_inc)

As it is, only the cos_inc contribution to the hastings_extra_factor is taken care of. I think the = operators for the other parameters except the first one (log10_h) should be changed to *=.

@AaronDJohnson AaronDJohnson added the bug Something isn't working label Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants