Aarch64 GIC: adding locking for concurrently accessed resources #2073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some resources contained in the static gic structure (namely, the ITS command queue, the device list, and the ITS interrupt map) can be accessed concurrently by different vCPUS, for example when gic_percpu_init() is called by secondary vCPUs when they are brought up. Add a spinlock to protect these resources from concurrent access; this fixes sporadic boot failures on Aarch64 instances with more than vCPUs.
francescolavra
force-pushed
the
fix/gic-lock
branch
from
8ce05ef
to
1035180
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some resources contained in the static gic structure (namely, the ITS command queue, the device list, and the ITS interrupt map) can be accessed concurrently by different vCPUS, for example when gic_percpu_init() is called by secondary vCPUs when they are brought up.
Add a spinlock to protect these resources from concurrent access; this fixes sporadic boot failures on Aarch64 instances with more than 2 vCPUs.