Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR: Support 3D touch / peek & pop #84

Open
brunolemos opened this issue Dec 17, 2017 · 9 comments
Open

FR: Support 3D touch / peek & pop #84

brunolemos opened this issue Dec 17, 2017 · 9 comments

Comments

@brunolemos
Copy link

brunolemos commented Dec 17, 2017

Support previewing the safari view using "Peek & Pop" before actually opening it.

@koenpunt
Copy link
Collaborator

Can you elaborate on what exactly you’re asking for?

@brunolemos
Copy link
Author

brunolemos commented Dec 18, 2017

Hi @koenpunt, I mean a way to do this on iPhone 6S and newer:

Gif

@koenpunt
Copy link
Collaborator

I just tested this somewhere where I implemented this library, and it just works by default. So unless I don't understand you correctly, this ticket can be closed.

@brunolemos
Copy link
Author

brunolemos commented Dec 18, 2017

@koenpunt Sorry, I wasn't clear. I don't mean inside the safari view. I mean before we open the link using this lib, got it? Like, I have a component that when I click it calls SafariView.show({.... I would need somehow force touch this component and preview the page content that SafariView will open.

@koenpunt
Copy link
Collaborator

A I see. Not sure if that should the responsibility of this library, but I'll see if I find some time to look into it. Or if you have any idea, I encourage you to open a PR.

@brunolemos
Copy link
Author

brunolemos commented Dec 18, 2017

I use react-native-navigation and they recently added this feature to their lib (implementation).
They ask for a component ref for it to work.

But react-native-safari-view just expose static methods, so I don't know what would be the best approach to integrate 3d touch feature.

@caiovncius
Copy link

caiovncius commented Mar 1, 2018

Hello. Anyone have any example how to can i do this? I try like the documentation but I don`t have success.

Thanks.

@koenpunt
Copy link
Collaborator

koenpunt commented Mar 1, 2018

Btw, is this even natively supported for SFSafariViewController?

@ptmt
Copy link
Contributor

ptmt commented May 22, 2018

Yes, it's supported. Quite nice actually, you get out-of-the-box actions such as Add To Reading List and Open in Safari. I managed to implement that, but by relying on react-native-navigation. Will try to think how to extract this code and send pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants