New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken benchmark link on npmjs? #925

Closed

melroy89 opened this issue Nov 4, 2024 · 4 comments

melroy89 commented Nov 4, 2024

On: https://www.npmjs.com/package/@node-rs/argon2

Benchmarks
See benchmark/.

The link to the benchmark is broken, it doesn't exists anymore!?

You might want to update or remove this.

millette commented Dec 29, 2024 •

edited

Loading

@melroy89 It was moved to https://github.com/napi-rs/node-rs/blob/main/packages/argon2/benchmark/argon2.ts

Link is fixed in https://github.com/napi-rs/node-rs/blob/main/packages/argon2/README.md

Author

melroy89 commented Dec 29, 2024

Yes. But somebody still need to update the link on npm.

millette commented Dec 30, 2024

That will only happen with the next release. When will that be? Your guess is as good as mine :-)

melroy89 closed this as completed

Author

melroy89 commented Dec 30, 2024

Assuming there will be a new release.. CLosing the ticket as "solved" for now..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment