You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The spec says they can't be negative, but sometimes the implementation lets negative numbers through. E.g.:
[I] bocchino@MT-306179 ~> cat test.fpp
module Fw {
port Log
port LogText
port Time
}
passive component C {
event port eventOut
time get port timeGetOut
text event port textEventOut
event E severity activity high id -1 format "Event E happened"
}
[I] bocchino@MT-306179 ~> fpp-check test.fpp
[I] bocchino@MT-306179 ~>
Per FPP Integer Limitations #198 we should use BigInt instead of Int to represent integer values that don't have specified bounds.
There are other miscellaneous issues involving integer bounds. E.g., parsing a large integer in a floating-point format shouldn't cause a crash.
Revise implementation
Add unit tests
Revise spec to bound integers that are implemented as Int, e.g., port numbers
The text was updated successfully, but these errors were encountered:
@LeStarch FYI. This fix will go into the v1.2.0 release that includes C++ port generation. Tiffany has completed FPP development for that release and is working on the F Prime functional unit tests.
IDs and opcodes have two issues:
There are other miscellaneous issues involving integer bounds. E.g., parsing a large integer in a floating-point format shouldn't cause a crash.
The text was updated successfully, but these errors were encountered: