Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/issue 229 add joss info #234

Merged
merged 3 commits into from
Jun 13, 2024

Conversation

danielfromearth
Copy link
Collaborator

@danielfromearth danielfromearth commented Jun 13, 2024

GitHub Issue: #229

Description

This change updates the CITATION and README with JOSS info.

Local test steps

N/A

Overview of integration done

N/A

PR Acceptance Checklist

  • [n/a] Unit tests added/updated and passing.
  • [n/a] Integration testing
  • CHANGELOG.md updated
  • Documentation updated (if needed).

📚 Documentation preview 📚: https://ncompare--234.org.readthedocs.build/en/234/

@danielfromearth danielfromearth linked an issue Jun 13, 2024 that may be closed by this pull request
Copy link

codecov bot commented Jun 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.10%. Comparing base (7e1bd99) to head (fd6f450).
Report is 77 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #234   +/-   ##
========================================
  Coverage    90.10%   90.10%           
========================================
  Files            6        6           
  Lines          475      475           
========================================
  Hits           428      428           
  Misses          47       47           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danielfromearth danielfromearth merged commit 3b602ac into develop Jun 13, 2024
11 checks passed
@danielfromearth danielfromearth deleted the feature/issue-229-add-joss-info branch July 5, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add JOSS info after acceptance
1 participant