Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional Credentials to nats-kafka #845

Merged
merged 8 commits into from
Dec 14, 2023

Conversation

ChrisDizenzo1047
Copy link
Contributor

@ChrisDizenzo1047 ChrisDizenzo1047 commented Dec 14, 2023

Description

The nats-kafka helm chart does not allow for passing in the UserCredential variable defined in the nats-kafka config here.

This PR allows for the creation of a credential volume, the credential as a secret to the credential volume, and adds the usercredential file-path using the secret key to the UserCredential field in the nats section of the nats-kafka config.

Testing

Tested the forked changes on our end and was able to use a secret to connect to a nats server with credentialed authentication.

@ChrisDizenzo1047 ChrisDizenzo1047 changed the title Add optional userCredentials to nats-kafka Add optional Credentials to nats-kafka Dec 14, 2023
ChrisDizenzo1047 and others added 3 commits December 14, 2023 16:35
Co-authored-by: Caleb Lloyd <2414837+caleblloyd@users.noreply.github.com>
Co-authored-by: Caleb Lloyd <2414837+caleblloyd@users.noreply.github.com>
Co-authored-by: Caleb Lloyd <2414837+caleblloyd@users.noreply.github.com>
@ChrisDizenzo1047
Copy link
Contributor Author

I was able to recently test these forked changes and was able to build the template and use it to authenticate with our local dev nats server using the same structure as the example in the readme

@caleblloyd
Copy link
Contributor

Great! A couple more recommendations then we can merge:

  1. In the values.yaml can you add a commented out section showing how to use, similar to how nack does it

  2. Can you bump the patch version of the chart in Chart.yaml so it'll release a new version when the PR merges

@caleblloyd caleblloyd merged commit f3ba282 into nats-io:main Dec 14, 2023
4 checks passed
@ChrisDizenzo1047 ChrisDizenzo1047 deleted the nats-kafka-user-credential branch December 15, 2023 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants