-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add optional Credentials to nats-kafka #845
Add optional Credentials to nats-kafka #845
Conversation
Co-authored-by: Caleb Lloyd <2414837+caleblloyd@users.noreply.github.com>
Co-authored-by: Caleb Lloyd <2414837+caleblloyd@users.noreply.github.com>
Co-authored-by: Caleb Lloyd <2414837+caleblloyd@users.noreply.github.com>
I was able to recently test these forked changes and was able to build the template and use it to authenticate with our local dev nats server using the same structure as the example in the readme |
Great! A couple more recommendations then we can merge:
|
Description
The nats-kafka helm chart does not allow for passing in the
UserCredential
variable defined in the nats-kafka config here.This PR allows for the creation of a credential volume, the credential as a secret to the credential volume, and adds the usercredential file-path using the secret key to the UserCredential field in the
nats
section of thenats-kafka
config.Testing
Tested the forked changes on our end and was able to use a secret to connect to a nats server with credentialed authentication.