Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kv.Update() doc to mention TTL #1725

Closed
fmontorsi-equinix opened this issue Oct 14, 2024 · 2 comments · Fixed by #1727
Closed

Update kv.Update() doc to mention TTL #1725

fmontorsi-equinix opened this issue Oct 14, 2024 · 2 comments · Fixed by #1727
Labels
proposal Enhancement idea or proposal

Comments

@fmontorsi-equinix
Copy link
Contributor

Proposed change

In the docs for the KeyValue.Update() method (https://pkg.go.dev/github.com/nats-io/nats.go/jetstream#KeyValue.Update) there is no mention of what happens to the TTL associated with the key.
I think/hope that the TTL gets reset.
I think docs should be enhanced to mention that.

Use case

Since Jetstream KV supports TTL, there must be a way to extend TTL somehow...

Contribution

I can contribute the doc enhancement, sure

@fmontorsi-equinix fmontorsi-equinix added the proposal Enhancement idea or proposal label Oct 14, 2024
@Jarema
Copy link
Member

Jarema commented Oct 16, 2024

You are right. The TTL will get refreshed.
We're happy to accept contribution here!

@fmontorsi-equinix
Copy link
Contributor Author

You are right. The TTL will get refreshed. We're happy to accept contribution here!

Ok thanks for confirming that. I opened #1727 to update the docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proposal Enhancement idea or proposal
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants