Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrap js publish error #1513

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

yeqown
Copy link

@yeqown yeqown commented Jan 9, 2024

ErrInvalidJsAck is not explicit in analysing or locating the error cause, so add an external message makes error clear.

helpful in issue #1512

@Jarema
Copy link
Member

Jarema commented Jan 11, 2024

Thank you for the PR!

We need to think twice about it, as this is technically a breaking chance for anyone relying on comparing errors with ==, but at the same time error.Is() is a idiomatic approach.

@yeqown
Copy link
Author

yeqown commented Feb 2, 2024

@Jarema What about printing logs here, rather than wrapping error, since it's helpul in my situation, I do want to output some abundant info here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants