-
Notifications
You must be signed in to change notification settings - Fork 703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IMPROVE] Mention TTL in the Update function #1727
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jarema
changed the title
Mention TTL in the Update function
[IMPROVE] Mention TTL in the Update function
Oct 17, 2024
Jarema
approved these changes
Oct 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Thank you for your contribution!
piotrpio
approved these changes
Oct 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
[like] Francesco Montorsi reacted to your message:
…________________________________
From: Tomasz Pietrek ***@***.***>
Sent: Thursday, October 17, 2024 11:17:08 AM
To: nats-io/nats.go ***@***.***>
Cc: Francesco Montorsi ***@***.***>; Author ***@***.***>
Subject: [EXTERNAL] Re: [nats-io/nats.go] [IMPROVE] Mention TTL in the Update function (PR #1727)
@Jarema approved this pull request.
LGTM.
Thank you for your contribution!
—
Reply to this email directly, view it on GitHub<https://urldefense.com/v3/__https://github.com/nats-io/nats.go/pull/1727*pullrequestreview-2374910167__;Iw!!PcPv50trKLWG!yvKQeTXpxlDlD5KJu0cKgn7gUScN-ue2PPbYYQted4u8EGiw8JbxGGB2_-O6rsebe6Z3LLr_ZO5qVOpaJkTdLeq0WI3U4Kizq5s$>, or unsubscribe<https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/BHQ6QLRTPOYZOVBJHPHTKRDZ36MDJAVCNFSM6AAAAABQDKWWBCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGNZUHEYTAMJWG4__;!!PcPv50trKLWG!yvKQeTXpxlDlD5KJu0cKgn7gUScN-ue2PPbYYQted4u8EGiw8JbxGGB2_-O6rsebe6Z3LLr_ZO5qVOpaJkTdLeq0WI3UEmHEInA$>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
This email is from Equinix (EMEA) B.V. or one of its associated companies in the territory from where this email has been sent. This email, and any files transmitted with it, contains information which is confidential, is solely for the use of the intended recipient and may be legally privileged. If you have received this email in error, please notify the sender and delete this email immediately. Equinix (EMEA) B.V.. Registered Office: Amstelplein 1, 1096 HA Amsterdam, The Netherlands. Registered in The Netherlands No. 57577889.
|
[like] Francesco Montorsi reacted to your message:
…________________________________
From: Piotr Piotrowski ***@***.***>
Sent: Thursday, October 17, 2024 11:20:45 AM
To: nats-io/nats.go ***@***.***>
Cc: Francesco Montorsi ***@***.***>; Author ***@***.***>
Subject: [EXTERNAL] Re: [nats-io/nats.go] [IMPROVE] Mention TTL in the Update function (PR #1727)
@piotrpio approved this pull request.
LGTM!
—
Reply to this email directly, view it on GitHub<https://urldefense.com/v3/__https://github.com/nats-io/nats.go/pull/1727*pullrequestreview-2374916844__;Iw!!PcPv50trKLWG!wqzd3U2ck91tOEq2O1dVvMOWxa5pWF5_rf55uZb9TROxRF1yYWAl0GP3Y9PplhZF-ULjfY3KpkAHehfgNwSy2oQ2CqSNIkDd4pI$>, or unsubscribe<https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/BHQ6QLU7JMZR5Q6RUMS2W7TZ36MQ3AVCNFSM6AAAAABQDKWWBCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGNZUHEYTMOBUGQ__;!!PcPv50trKLWG!wqzd3U2ck91tOEq2O1dVvMOWxa5pWF5_rf55uZb9TROxRF1yYWAl0GP3Y9PplhZF-ULjfY3KpkAHehfgNwSy2oQ2CqSNsCRLQWE$>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
This email is from Equinix (EMEA) B.V. or one of its associated companies in the territory from where this email has been sent. This email, and any files transmitted with it, contains information which is confidential, is solely for the use of the intended recipient and may be legally privileged. If you have received this email in error, please notify the sender and delete this email immediately. Equinix (EMEA) B.V.. Registered Office: Amstelplein 1, 1096 HA Amsterdam, The Netherlands. Registered in The Netherlands No. 57577889.
|
piotrpio
pushed a commit
that referenced
this pull request
Dec 13, 2024
piotrpio
pushed a commit
that referenced
this pull request
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1725