Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify handling of prepost/partner specification in connectivity queries #63

Open
jefferis opened this issue Jan 30, 2020 · 3 comments

Comments

@jefferis
Copy link
Contributor

I'd actually be in favor of changing for input/output across all functions -- which will certainly break existing analysis code but should be for the best in the long term. Merge into a dev branch?

Originally posted by @romainFr in #61

@IsabelDAlessandro
Copy link

Similar to this concern, I've found the documentation for the output of neuprint_get_synapses() to be somewhat confusing in its description of what prepost=0 and prepost=1 mean.

The current documentation reads: "a data frame, where each entry is a connection between the specified bodyid and its partner, either presynaptic to the bodyid (prepost=0) or postsynaptic (prepost=1).... "

Perhaps the name 'prepost' could be changed to something more descriptive. Alternatively, the documentation could be modified for clarity to read something like:

“Value: A data frame, where each entry is a synaptic connection between the specified bodyid and one partner neuron. Entries with prepost=0 indicate a connection where the partner is postsynaptic to the queried neuron (bodyids in the ‘partners’ column are outputs of the queried neuron). Entries with prepost=1 indicate a connection where the partner is presynaptic to the queried neuron (bodyids in the ‘partners’ column are inputs to the queried neuron)....”

jefferis added a commit that referenced this issue Jun 1, 2020
* Partly in response to @IsabelDAlessandro in #63
* also a few other small doc fixes while I was at it
@jefferis
Copy link
Contributor Author

jefferis commented Jun 1, 2020

Thanks @IsabelDAlessandro. As you can see I've never been that keen on this notation myself, but given that I didn't take action sooner, it's not something that we can now remove completely. I will see if we can provide an alternate mechanism but for now I have updated the documentation along the lines that you suggest. Please see ?neuprint_get_synapses or (in a few mins) http://natverse.org/neuprintr/reference/neuprint_get_synapses.html

@schlegelp
Copy link

Is there a way to deprecate the column and make a step-wise transition starting with having a additional column with the same data but a more descriptive name or values, and then eventually removing the prepost column altogether?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants