Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Event JSON tags #133

Closed
ice-dionysos opened this issue Jul 15, 2024 · 2 comments
Closed

Event JSON tags #133

ice-dionysos opened this issue Jul 15, 2024 · 2 comments

Comments

@ice-dionysos
Copy link

I see that all JSON tags were removed here 2bf6c87

Any reason why? Could we bring them back?

Thanks.
@fiatjaf
Copy link
Collaborator

fiatjaf commented Jul 15, 2024

They were not being used, as the Event and Filter types implement custom JSON marshalers and unmarshalers. Is that not working for you?

@ice-dionysos
Copy link
Author

Yeah, you are right.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fiatjaf @ice-dionysos