Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SUSHI Confirmation page error #25

Open
dineshranjan opened this issue Aug 15, 2015 · 3 comments
Open

SUSHI Confirmation page error #25

dineshranjan opened this issue Aug 15, 2015 · 3 comments
Labels

Comments

@dineshranjan
Copy link

When the usage is updated for previous year via SUSHI, the upload confirmation page by default takes the current year. I hope its caused by the $checkYear parameter which is taken as the current year. The year should be taken from the xml file stored in the SUSHI store. I am trying to figure out where to make the changes for obtaining the correct year from the xml file during upload confirmation.

@jeffnm
Copy link
Contributor

jeffnm commented Dec 7, 2015

This is more than just the confirmation page display. It actually impacts which year in the database the imported data is entered into. This is a serious problem.

@jeffnm jeffnm added the bug label Dec 7, 2015
@jeffnm
Copy link
Contributor

jeffnm commented Dec 7, 2015

I think one solution is to have the SushiService.php function that writes the import file that is kept in archive/ create the standard header for a regular import file, rather than just the values as it currently does. Then the standard import code could be used to parse the year out of the column names.

@coraladmin
Copy link

This seems like a fine solution to me. The overall bug is very significant and needs to be addressed asap. It has severely messed up our usage data.

Steve

From: Discussion List for CORAL ERM Administrators <CORAL-ADMIN@LISTSERV.ND.EDUmailto:CORAL-ADMIN@LISTSERV.ND.EDU> on behalf of Jeffrey Mudge <notifications@github.commailto:notifications@github.com>
Reply-To: ndlibersa/usage <reply@reply.github.commailto:reply@reply.github.com>
Date: Monday, December 7, 2015 at 11:26 AM
To: "CORAL-ADMIN@LISTSERV.ND.EDUmailto:CORAL-ADMIN@LISTSERV.ND.EDU" <CORAL-ADMIN@LISTSERV.ND.EDUmailto:CORAL-ADMIN@LISTSERV.ND.EDU>
Subject: Re: [CORAL-ADMIN] [usage] SUSHI Confirmation page error (#25)

I think one solution is to have the SushiService.php function that writes the import file that is kept in archive/ create the standard header for a regular import file, rather than just the values as it currently does. Then the standard import code could be used to parse the year out of the column names.


Reply to this email directly or view it on GitHubhttps://github.com//issues/25#issuecomment-162599644.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants