Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

return_copy should probably be dropped from kwargs when checking cache hits #80

Open
Tracked by #65
kushalkolar opened this issue Jul 29, 2022 · 1 comment
Open
Tracked by #65

return_copy should probably be dropped from kwargs when checking cache hits #80

kushalkolar opened this issue Jul 29, 2022 · 1 comment

Comments

@kushalkolar
Copy link
Collaborator

@clewis7 posting this because it just popped into my head, don't worry about it until you're back

the return_copy kwarg is irrelevant for determine a cache hit/miss therefore it should be dropped for the comparison.
@kushalkolar kushalkolar modified the milestones: v0.1, v0.2 Jul 30, 2022
@kushalkolar
Copy link
Collaborator Author

should probably have return_copy be a kwarg only, using the <optional_as_kwarg>,*,<mandatory_as_kwargs> syntax

@kushalkolar kushalkolar mentioned this issue Jan 9, 2023
Closed
14 tasks
@kushalkolar kushalkolar removed this from the v0.2 milestone Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kushalkolar