-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor version updates and code polishes #395
Open
seabamirum
wants to merge
18
commits into
neo4j-contrib:master
Choose a base branch
from
seabamirum:neo4j-latest-java21
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Andy2003
requested changes
May 28, 2024
src/main/java/org/geotools/data/neo4j/Neo4jSpatialDataStore.java
Outdated
Show resolved
Hide resolved
…eabamirum/neo4j-latest-java21 # Conflicts: # pom.xml # src/main/java/org/geotools/data/neo4j/Neo4jSpatialDataStore.java # src/main/java/org/geotools/data/neo4j/Neo4jSpatialDataStoreFactory.java # src/main/java/org/neo4j/gis/spatial/DefaultLayer.java # src/main/java/org/neo4j/gis/spatial/DynamicLayer.java # src/main/java/org/neo4j/gis/spatial/DynamicLayerConfig.java # src/main/java/org/neo4j/gis/spatial/OrderedEditableLayer.java # src/main/java/org/neo4j/gis/spatial/ShapefileImporter.java # src/main/java/org/neo4j/gis/spatial/SpatialDatabaseRecord.java # src/main/java/org/neo4j/gis/spatial/SpatialDatabaseService.java # src/main/java/org/neo4j/gis/spatial/SpatialTopologyUtils.java # src/main/java/org/neo4j/gis/spatial/WKBGeometryEncoder.java # src/main/java/org/neo4j/gis/spatial/WKTGeometryEncoder.java # src/main/java/org/neo4j/gis/spatial/attributes/PropertyMappingManager.java # src/main/java/org/neo4j/gis/spatial/encoders/NativePointEncoder.java # src/main/java/org/neo4j/gis/spatial/encoders/SimpleGraphEncoder.java # src/main/java/org/neo4j/gis/spatial/encoders/neo4j/Neo4jGeometry.java # src/main/java/org/neo4j/gis/spatial/filter/SearchCQL.java # src/main/java/org/neo4j/gis/spatial/index/ExplicitIndexBackedPointIndex.java # src/main/java/org/neo4j/gis/spatial/index/IndexManager.java # src/main/java/org/neo4j/gis/spatial/index/LayerGeohashPointIndex.java # src/main/java/org/neo4j/gis/spatial/index/LayerHilbertPointIndex.java # src/main/java/org/neo4j/gis/spatial/index/LayerSpaceFillingCurvePointIndex.java # src/main/java/org/neo4j/gis/spatial/index/LayerZOrderPointIndex.java # src/main/java/org/neo4j/gis/spatial/osm/OSMDataset.java # src/main/java/org/neo4j/gis/spatial/osm/OSMGeometryEncoder.java # src/main/java/org/neo4j/gis/spatial/osm/OSMImporter.java # src/main/java/org/neo4j/gis/spatial/osm/OSMLayer.java # src/main/java/org/neo4j/gis/spatial/pipes/AbstractExtractGeoPipe.java # src/main/java/org/neo4j/gis/spatial/pipes/AbstractGroupGeoPipe.java # src/main/java/org/neo4j/gis/spatial/pipes/GeoPipeline.java # src/main/java/org/neo4j/gis/spatial/pipes/impl/AbstractPipe.java # src/main/java/org/neo4j/gis/spatial/pipes/impl/Pipeline.java # src/main/java/org/neo4j/gis/spatial/pipes/impl/RangeFilterPipe.java # src/main/java/org/neo4j/gis/spatial/pipes/processing/OrthodromicDistance.java # src/main/java/org/neo4j/gis/spatial/procedures/SpatialProcedures.java # src/main/java/org/neo4j/gis/spatial/rtree/EmptyMonitor.java # src/main/java/org/neo4j/gis/spatial/rtree/Envelope.java # src/main/java/org/neo4j/gis/spatial/rtree/ProgressLoggingListener.java # src/main/java/org/neo4j/gis/spatial/rtree/RTreeImageExporter.java # src/main/java/org/neo4j/gis/spatial/rtree/RTreeIndex.java # src/main/java/org/neo4j/gis/spatial/rtree/RTreeMonitor.java # src/main/java/org/neo4j/gis/spatial/utilities/LayerUtilities.java # src/test/java/org/neo4j/gis/spatial/procedures/SpatialProceduresTest.java
…eabamirum/neo4j-latest-java21 # Conflicts: # pom.xml
@seabamirum Have you already signed the CLA? |
…latest-java21 # Conflicts: # pom.xml # src/main/java/org/neo4j/gis/spatial/rtree/RTreeIndex.java
Merge master into neo4j-latest-java21
https://github.com/seabamirum/neo4j-spatial-5.git into neo4j-latest-java21
Yes, I have signed the CLA. I think this branch is all properly synced up now.. |
Andy2003
requested changes
May 31, 2024
@craigtaverner May you take a look at these changes? |
Andy2003
force-pushed
the
master
branch
5 times, most recently
from
June 20, 2024 15:01
6844765
to
bee28a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
else
clauses that were followed by anif
block with areturn
static
modifier to static methods when suggested by compilermakeLayerInstance
, replaced deprecatednewInstance
method withgetDeclaredConstructor().newInstance()