change scroll into view selector (#1864)

neo4j · Nov 21, 2022 · bfa05d6 · bfa05d6
1 parent f1fe810
commit bfa05d6
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/e2e_tests/integration/viz.spec.ts b/e2e_tests/integration/viz.spec.ts
@@ -267,8 +267,9 @@ describe('Viz rendering', () => {
 
     // Check that can scroll overview panel
     const showAllButtonText = 'Show all'
-    cy.get(`button:contains("${showAllButtonText}")`).scrollIntoView()
-    cy.get(`button:contains("${showAllButtonText}")`).should('be.visible')
+    cy.get(`button:contains("${showAllButtonText}")`)
+      .scrollIntoView()
+      .should('be.visible')
 
     // Open node properties details panel
     const nodeSelector = '.node'
@@ -282,7 +283,7 @@ describe('Viz rendering', () => {
     cy.contains(lastPropName).should('exist')
 
     // For some reason need to get to the td to be able to scroll to it, hence the parent()
-    cy.get('tr td span').contains(lastPropName).parent().scrollIntoView()
+    cy.get('[data-testid="viz-details-pane-body"]').scrollTo('bottom')
     cy.get('tr td span').contains(lastPropName).should('be.visible')
   })
 })
diff --git a/...owser/modules/Stream/CypherFrame/VisualizationView/PropertiesPanelContent/DetailsPane.tsx b/...owser/modules/Stream/CypherFrame/VisualizationView/PropertiesPanelContent/DetailsPane.tsx
@@ -86,7 +86,7 @@ export function DetailsPane({
             )
           })}
       </PaneHeader>
-      <PaneBody>
+      <PaneBody data-testid="viz-details-pane-body">
         <PropertiesTable
           visibleProperties={visibleItemProperties}
           onMoreClick={handleMorePropertiesClick}