Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Results are often prefixed with localhost:port which result in 404 #631

Open
stef204 opened this issue Nov 15, 2024 · 5 comments · May be fixed by #640
Open

🐛 Results are often prefixed with localhost:port which result in 404 #631

stef204 opened this issue Nov 15, 2024 · 5 comments · May be fixed by #640

Comments

@stef204
Copy link

stef204 commented Nov 15, 2024

Description

On branch rolling.

Very often, when searching, the results page will show a number of links to websites/webpages which include both valid links and invalid ones--resulting in error 404.

The invalid links are prefixed with http://localhost:port/ which of course results in 404.

One can just hover the mouse over the various results and see which links are valid and which are not.

This is definitely something which needs to be resolved. Unless I my config file is misconfigured, creating the problem.

Screenshots

No response

Do you want to work on this issue?

None

Additional information

config.lua is here

Copy link

To reduce notifications, issues are locked until they are 🏁 status: ready for dev and to be assigned. You can learn more in our contributing guide https://github.com/neon-mmd/websurfx/blob/rolling/CONTRIBUTING.md

@github-actions github-actions bot locked and limited conversation to collaborators Nov 15, 2024
@neon-mmd neon-mmd changed the title websurfx results often prefixed with "localhost:port" resulting in 404 🐛 Results are often prefixed with "localhost:port" which result in 404 Dec 5, 2024
@neon-mmd neon-mmd changed the title 🐛 Results are often prefixed with "localhost:port" which result in 404 🐛 Results are often prefixed with localhost:port which result in 404 Dec 5, 2024
@github-actions github-actions bot unlocked this conversation Dec 5, 2024
Copy link

github-actions bot commented Dec 5, 2024

The issue has been unlocked and is now ready for dev. If you would like to work on this issue, you can comment to have it assigned to you. You can learn more in our contributing guide https://github.com/neon-mmd/websurfx/blob/rolling/CONTRIBUTING.md

@neon-mmd
Copy link
Owner

neon-mmd commented Dec 5, 2024

Sorry for the late reply.

Thanks ❤️ for taking the time to report this issue. We really appreciate it as this helps improves the project. 🙂 .

My best guess is this issue maybe due to breaking API changes from the upstream search engines which could be causing the wrong search results being grabbed from the above search engines rather than from the config file. @jfvillablanca What do you think? Also, if you are free, could you investigate more into this. 😅

@jfvillablanca
Copy link
Collaborator

jfvillablanca commented Dec 10, 2024

Yeah, I think you might be right, it probably has something to do breaking changes upstream. I'll take a look at this

If you could provide a minimal way to reproduce this issue, I would be most grateful 😄

Edit:
I think the affected engine is Mojeek; currently investigating

@stef204
Copy link
Author

stef204 commented Dec 10, 2024

I've been waiting 3 weeks to mention that this seems to only happen with the mojeek search engine ;)
So enable that in config.lua and search, look at results.
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment