-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
💄 Modernize the appearance of about page and make it responsive. #530
Conversation
…olling update local repo
Co-authored-by: neon_arch <mustafadhuleb53@gmail.com>
…ith proper rust formatting
…ls, add blank lines to before rule declarations and between font-face rules
…iterals to conform with proper rust formatting
… before first rule inside media queries
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the late review.
Thanks ❤️ for working on this PR. We really appreciate it 👍 Keep it up!! but before we merge this PR. We would suggest the following changes. 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay in the reply.
One last small suggestion, I feel it would be better to have all the media queries
at the end of the file so that anyone else working on this future does not get confused or lost when searching/editing media queries. Moreover, I think it would make the code consistent too. What do you think? 🙂
I believe they are already at the bottom-most part of the file. |
Ok I see, I am sorry, I think I overlooked it. Thanks ❤️ for pointing it out. 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks ❤️ again for working on this. Since everything looks good. We will merge this PR as soon as possible. 🙂
What does this PR do?
This PR modifies
simple.css
to include better padding, margin, alignment and introduce RWD (responsive web design) to the about page.Preview/Screenshots
Small Screen Devices
Large Screen Devices
Why is this change important?
The current about's page is painfully outdated and not mobile-friendly. This hopes to fix that.
Related issues
Closes #433