Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multi/exec support #1

Open
chloe-zen opened this issue Jul 22, 2011 · 3 comments
Open

multi/exec support #1

chloe-zen opened this issue Jul 22, 2011 · 3 comments

Comments

@chloe-zen
Copy link

SV * _read_bulk_reply (Redis__hiredis self, redisReply *reply) {
SV *sv;
if ( reply->type == REDIS_REPLY_ERROR ) {
croak("%s",reply->str);
}

When you use MULTI/EXEC, bulk replies can include errors.

@neophenix
Copy link
Owner

How very annoying. An easy fix is done, but I am not sure I like it so I will think about it a little longer. Thanks for opening the issue.

@neophenix
Copy link
Owner

Well, I don't like that I now croak on errors in a single reply, and just return the strings in a multi bulk, but for now this works so I pushed it up here. I'm going to look at doing the returns differently in the future while hopefully not hosing BC.

"Fixed" in : SHA: cc30418

@chloe-zen
Copy link
Author

AnyEvent::Redis uses an AE::R::Error object, which can be batched as well as returned alone. One of the multitude of exception classes might serve you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants