You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I know that switch in php are loose comparison == and thought at first "off" == false but the falsy string are "0" and "".
What really happens is that ANY truthy string will pass the check and turn auto-wiring ON!!
That includes the strings "off""on" and "nudelsuppe" ... !!!
That means that, as we use "off" in our flow configuration code, is was useless all the time and turned autowiring ON.
While testing #2956 i found out that flow crashes with:
At first i was more confused by the mention of
DateTime
, that its A returned fromregisterClassFiles
AND that we declare an Objects.yaml for it??flow-development-collection/Neos.Flow/Configuration/Objects.yaml
Lines 10 to 12 in 416af25
But it turns out that the method
parseAutowiring
was made stricter in the mentioned pr and currently allows also"off"
:flow-development-collection/Neos.Flow/Classes/ObjectManagement/Configuration/ConfigurationBuilder.php
Lines 316 to 321 in 2a46c5f
I know that
switch
in php are loose comparison==
and thought at first"off" == false
but the falsy string are"0"
and""
.What really happens is that ANY truthy string will pass the check and turn auto-wiring ON!!
That includes the strings
"off"
"on"
and"nudelsuppe"
... !!!That means that, as we use
"off"
in our flow configuration code, is was useless all the time and turned autowiring ON.This is a regression from this change in 2011, which turned '"on"' in the switch case to
true
and"off"
tofalse
.0284ce6#diff-8a640f9bc0ed3edffb3f01425b0206a17d9ece5c16d04d8cca4c043ee6ca19f6R243
The text was updated successfully, but these errors were encountered: