Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Dont group Objects.yaml by package name #3321

Open
mhsdesign opened this issue Feb 21, 2024 · 2 comments
Open

WIP: Dont group Objects.yaml by package name #3321

mhsdesign opened this issue Feb 21, 2024 · 2 comments

Comments

@mhsdesign
Copy link
Member

Was that always the case? I mean why the hell do we separate the object configuration by package LOL. But that's for another PR / ticket

Originally posted by @kitsunet in #3318 (comment)

@kitsunet
Copy link
Member

I think I know why, because we use that information in proxy building, BUT a) I am not even sure it needs to be that way (apart from debugging information, but I have some ideas regarding that) and b) We could still provide it differently at runtime. Sounds weird but that could actually make sense, aaaaand STOP all that, writing this down actually gave me the answer.....

For the respective use case we already HAVE a way better way to do this, namely:

\Neos\Flow\ObjectManagement\ObjectManagerInterface::getClassNameByObjectName(), this should just return the right implementation as in, the chosen one the objectmanager would inject if you asked it, and that's all we need and we have an object manager, at least compiletime which also can answer this question.

@mhsdesign
Copy link
Member Author

Yes thanks wo i was just too blind and sure there is no better way 😅 Implemented here: #3322

But this issue may persist for that we had many WTFs why the config is not merged and this will possibly make the array bigger?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants