add ckb-c-stdlib as a submodule #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
contrun
force-pushed
the
update-ckb-c-stdlib
branch
from
548c564 to
56ac98b
Compare
contrun
force-pushed
the
update-ckb-c-stdlib
branch
from
6da4bfd to
21e0121
Compare
contrun
force-pushed
the
update-ckb-c-stdlib
branch
from
6854e7f to
48069fd
Compare
XuJiandong
requested changes
Sep 11, 2023
| @@ -5,7 +5,7 @@ CC := $(TARGET)-gcc | |||
| LD := $(TARGET)-gcc | |||
| OBJCOPY := $(TARGET)-objcopy | |||
|
|
|||
| CFLAGS := -fPIC -O3 -fno-builtin -nostdinc -nostdlib -nostartfiles -fvisibility=hidden -fdata-sections -ffunction-sections -I lualib -I include/ckb-c-stdlib -I include/ckb-c-stdlib/libc -I include/ckb-c-stdlib/molecule -Wall -Werror -Wno-nonnull -Wno-nonnull-compare -Wno-unused-function -g | |||
| CFLAGS := -D__ISO_C_VISIBLE=1999 -fPIC -O3 -fno-builtin -nostdinc -nostdlib -nostartfiles -fvisibility=hidden -fdata-sections -ffunction-sections -I lualib -I lualib/c-stdlib -I include/ckb-c-stdlib -I include/ckb-c-stdlib/libc -I include/ckb-c-stdlib/molecule -Wall -Werror -Wno-nonnull -Wno-nonnull-compare -Wno-unused-function -Wno-error=maybe-uninitialized -g | |||
There was a problem hiding this comment.
Why is this macro "__ISO_C_VISIBLE=1999" used?
There was a problem hiding this comment.
If __ISO_C_VISIBLE=1999 then LLONG_MAX is defined here https://github.com/nervosnetwork/ckb-c-stdlib/blob/efe1fe6b3cdda12e248e25664f5c04cbf7876265/libc/limits.h#L94 . Lua check the definition of LLONG_MAX https://github.com/nervosnetwork/ckb-lua/blob/b71d44288e8fb085074d3af056b359b8c6c22afa/lualib/luaconf.h#L502 to define a few things. This is somewhat dirty.
XuJiandong
approved these changes
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds ckb-c-stdlib as a git submodule. We have added quite a few functions to the ckb-c-stdlib (the complete list can be viewed from nervosnetwork/ckb-c-stdlib@master...contrun:ckb-c-stdlib:ckb-lua ). Theoretically we can use master branch of nervosnetwork/ckb-c-stdlib and add these functions to the ckb-lua repo, but keeping them in ckb-c-stdlib makes more sense. I currently use the this branch as a git submodule.