forked from contrun/ckb-lua
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add ckb-c-stdlib as a submodule #12
Merged
XuJiandong
merged 18 commits into
nervosnetwork:master
from
contrun:update-ckb-c-stdlib
Sep 11, 2023
+2,131
−16,839
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
816f244
update ckb-c-stdlib files from upstream
contrun 531ed07
define __ISO_C_VISIBLE as we need LLONG_MAX in lua
contrun 10d448e
use latest spawn api
contrun 2642387
remove vendored ckb-c-stdlib
contrun 56ac98b
use ckb-c-stdlib as submodule
contrun 4c80773
lock rust toolchain version otherwise procmacro2 will fail to build
contrun 50e1d07
use ckb-c-stdlib with minimal changes
contrun e02420d
add stdlib function locally
contrun 0f69aeb
fix not using the correct malloc implementation
contrun a8bb211
fix multiple definitions
contrun b52cb02
add correct printf with float support
contrun 21e0121
correctly implement printf
contrun 711bebe
fix implicit declaration of function 'malloc_config'
contrun 48069fd
fix malloc test
contrun c41aec1
move all c stdlib files to c-stdlib directory
contrun 42d65d8
make c-stdlib file names more consistent
contrun f8edde0
change ckb-c-stdlib submodule url
contrun 9516606
add comments of why __ISO_C_VISIBLE=1999 is needed
contrun File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
[submodule "include/ckb-c-stdlib"] | ||
path = include/ckb-c-stdlib | ||
url = https://github.com/nervosnetwork/ckb-c-stdlib.git |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Submodule ckb-c-stdlib
added at
bdc87e
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this macro "__ISO_C_VISIBLE=1999" used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If
__ISO_C_VISIBLE=1999
thenLLONG_MAX
is defined here https://github.com/nervosnetwork/ckb-c-stdlib/blob/efe1fe6b3cdda12e248e25664f5c04cbf7876265/libc/limits.h#L94 . Lua check the definition ofLLONG_MAX
https://github.com/nervosnetwork/ckb-lua/blob/b71d44288e8fb085074d3af056b359b8c6c22afa/lualib/luaconf.h#L502 to define a few things. This is somewhat dirty.