Skip to content

Commit

Permalink
chore(): release v0.1.2
Browse files Browse the repository at this point in the history
  • Loading branch information
@kamilmysliwiec
kamilmysliwiec committed Dec 19, 2022
1 parent 0445037 commit 297e937
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions package-lock.json
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@nestjs/axios",
"version": "0.1.0",
"version": "0.1.2",
"description": "Nest - modern, fast, powerful node.js web framework (@axios)",
"author": "Kamil Mysliwiec",
"license": "MIT",
Expand Down

7 comments on commit 297e937

@thenglong
Copy link

@thenglong thenglong commented on 297e937 Dec 19, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kamilmysliwiec May I know why the version is going down?! I have the 1.0.0 installed and now the latest version is 0.1.*

@kamilmysliwiec
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just fixed. Something must have gone wrong with release-it & pre-commit hooks

@SchroederSteffen
Copy link

@SchroederSteffen SchroederSteffen commented on 297e937 Dec 19, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, but that doesn't really answer it. It seems like you consider the 1.0.0 an error and you will stay on 0.1.x?
I'd like to propose to use 1.x, because this package is released and supposed to be used, right?
Or am I mis-interpreting it?

// Edit: If you won't use 1.x, the release should be marked as deprecated in the registry.

@kamilmysliwiec
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You did misinterpret it indeed 😄 I deprecated 0.1.x and 1.0.1 instead

@thenglong
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You did misinterpret it indeed 😄 I deprecated 0.1.x and 1.0.1 instead

That’s the answer. I assume it was just a wrong version with releasing.

@SchroederSteffen
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You did misinterpret it indeed 😄 I deprecated 0.1.x and 1.0.1 instead

Ah, perfect, thanks! 👍 Sorry for my confusion. 🙈 😅

Should 0.1.1 also be deprecated? (link)

image

@pc-bob
Copy link

@pc-bob pc-bob commented on 297e937 Dec 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears that 0.1.1 includes the axios upgrade and is a breaking change from 0.1.0. This version should be deleted if this was released on accident. Anyone pinning their version using ^ or ~ will unexpectedly receive a breaking change if left as is.

Please sign in to comment.