Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NB_{WIREGUARD_PORT,INTERFACE_NAME} is not supported by anything except netbird up #1562

Open
nazarewk opened this issue Feb 12, 2024 · 2 comments

Comments

@nazarewk
Copy link
Contributor

nazarewk commented Feb 12, 2024

Describe the problem

I am configuring wireguard interface/port using environment variables, but they do not get updated unless I run netbird up separately.

To Reproduce

Steps to reproduce the behavior:

  1. run netbird for the first time
  2. set Environment=NB_WIREGUARD_PORT=12345
  3. restart netbird.service
  4. netbird still runs on port 51820
  5. run netbird down
  6. run NB_WIREGUARD_PORT=12345 netbird up

Expected behavior

Netbrid starts on port 12345 with just systemd service change, not requiring separate down and up commands.

Are you using NetBird Cloud?

Yes

NetBird version

0.25.6

Additional context

Discovered while developing NixOS/nixpkgs#287236

@surik
Copy link
Contributor

surik commented Feb 13, 2024

The Current implementation doesn't cover service. We will need to extend this.

@nazarewk
Copy link
Contributor Author

nazarewk commented Feb 14, 2024

For more complete experience I think when netbird service run is configured with interface/port:

  1. it should have the highest priority
  2. should not be overridable by other tools at all
  3. should return errors/warning for other means of configuration netbird up / netbird-ui netbird-ui rolls back the daemon to default interface and port #1581

@nazarewk nazarewk changed the title NB_{WIREGUARD_PORT,INTERFACE_NAME} does not get updated by netbird service run NB_{WIREGUARD_PORT,INTERFACE_NAME} is not supported by anything excepy netbird up Feb 14, 2024
@nazarewk nazarewk changed the title NB_{WIREGUARD_PORT,INTERFACE_NAME} is not supported by anything excepy netbird up NB_{WIREGUARD_PORT,INTERFACE_NAME} is not supported by anything except netbird up Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants