Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table Issues #16850

Open
6 tasks
andrewgormley opened this issue Jul 8, 2024 · 3 comments
Open
6 tasks

Table Issues #16850

andrewgormley opened this issue Jul 8, 2024 · 3 comments
Assignees
Labels
status: accepted This issue has been accepted for implementation topic: UI/UX User interface or user experience related work type: feature Introduction of new functionality to the application
Milestone

Comments

@andrewgormley
Copy link
Collaborator

andrewgormley commented Jul 8, 2024

NetBox version

v4.1.0-dev

Feature type

Change to existing functionality

Proposed functionality

  • (Misc) Checkbox missing label [Multiple]
  • (Misc) Missing link text on hidden table column [Multiple]
  • (Tables) unlabelled column header for checkbox column [Multiple]
  • (Tables) Ensure tables use table and row headers to describe cells [Multiple]
  • (Tables) Row actions missing accessible names [Multiple]
  • (Tables) When table column is sorted the 'x' icon is missing link text [Multiple]

Use case

Fixing web accessibility issues ensures NetBox is best placed to serve users using screen readers and other accessibility tools.

Database changes

No response

External dependencies

No response

@andrewgormley andrewgormley added type: feature Introduction of new functionality to the application topic: UI/UX User interface or user experience related work labels Jul 8, 2024
@andrewgormley andrewgormley added this to the v4.1 milestone Jul 8, 2024
@andrewgormley andrewgormley self-assigned this Jul 8, 2024
@jeremystretch jeremystretch added the status: accepted This issue has been accepted for implementation label Jul 15, 2024
@andrewgormley
Copy link
Collaborator Author

  • (Misc) Missing link text on hidden table column [Multiple]
  • (Tables) unlabelled column header for checkbox column [Multiple]

These two issues appear to be related to the actions column, the missing link is due to the sortable option being set to true even though there is no label. I believe to fix both issues we should set the sortable option to false and label the column as 'actions' or similar.

Screenshot 2024-07-24 at 12 06 02

@andrewgormley
Copy link
Collaborator Author

  • (Misc) Checkbox missing label [Multiple]

This issue is due to the checkbox not having an associated label, however being in a table this is a bit of an edge case, this might be fixable with an aria label

Screenshot 2024-07-24 at 12 06 47

@andrewgormley
Copy link
Collaborator Author

I've moved more table issues from #16852 to here.

andrewgormley pushed a commit to andrewgormley/netbox that referenced this issue Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: accepted This issue has been accepted for implementation topic: UI/UX User interface or user experience related work type: feature Introduction of new functionality to the application
Projects
None yet
Development

No branches or pull requests

2 participants