Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge terraform provider tidydns #4

Merged
merged 4 commits into from
Dec 2, 2024
+458 −25
Merged

Merge terraform provider tidydns #4

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d2d0351
Merge functionality from terraform-provider-tidydns upstream
jenrik Nov 27, 2024
b4f3182
Code cleanup
jenrik Nov 27, 2024
a83211a
Cleanup comment
jenrik Nov 27, 2024
0bf3d59
Close HTTP response bodies
jenrik Nov 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
220 changes: 210 additions & 10 deletions pkg/tidydns/tidydns.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,20 @@ import (
"context"
"encoding/json"
"fmt"
"io"
"net/http"
"net/url"
"strconv"
"strings"
)

type TidyDNSClient interface {
GetSubnetIDs(ctx context.Context, subnetCIDR string) (*SubnetIDs, error)
GetFreeIP(ctx context.Context, subnetID int) (string, error)
CreateDHCPInterface(ctx context.Context, createInfo CreateInfo) (int, error)
ReadDHCPInterface(ctx context.Context, interfaceID int) (*InterfaceInfo, error)
UpdateDHCPInterfaceName(ctx context.Context, interfaceID int, interfaceName string) (int, error)
DeleteDHCPInterface(ctx context.Context, interfaceID int) error
ListZones(ctx context.Context) ([]*ZoneInfo, error)
FindZoneID(ctx context.Context, name string) (int, error)
CreateRecord(ctx context.Context, zoneID int, info RecordInfo) (int, error)
Expand Down Expand Up @@ -42,6 +49,7 @@ type CreateInfo struct {
ZoneID int
InterfaceIP string
InterfaceName string
LocationID int
}

type RecordInfo struct {
Expand All @@ -59,6 +67,7 @@ type LocationID int
type RecordType int
type RecordStatus int

//goland:noinspection GoUnusedConst
const (
RecordStatusActive RecordStatus = 0
RecordStatusInactive RecordStatus = 1
Expand Down Expand Up @@ -93,6 +102,187 @@ func New(baseURL, username, password string) TidyDNSClient {
}
}

func (c *tidyDNSClient) GetSubnetIDs(ctx context.Context, subnetCIDR string) (*SubnetIDs, error) {
req, err := http.NewRequestWithContext(ctx, "GET", fmt.Sprintf("%s/=/dhcp_subnet?subnet=%s", c.baseURL, subnetCIDR), nil)
if err != nil {
return nil, err
}

req.SetBasicAuth(c.username, c.password)

res, err := c.client.Do(req)
if err != nil {
return nil, err
}
if res.StatusCode != http.StatusOK {
return nil, fmt.Errorf("error from tidyDNS server: %s", res.Status)
}

// Check response code
jenrik marked this conversation as resolved.
Show resolved Hide resolved

var subnets []dhcpSubnet
err = json.NewDecoder(res.Body).Decode(&subnets)
if err != nil {
return nil, err
}

if len(subnets) == 0 {
return nil, fmt.Errorf("subnet not found: %s", subnetCIDR)
}

if len(subnets) > 1 {
return nil, fmt.Errorf("too many subnets found: %s", subnetCIDR)
}

return &SubnetIDs{
SubnetID: subnets[0].ID,
ZoneID: subnets[0].ZoneID,
VlanNo: subnets[0].VlanNo,
}, nil
}

func (c *tidyDNSClient) GetFreeIP(ctx context.Context, subnetID int) (string, error) {
req, err := http.NewRequestWithContext(ctx, "GET", fmt.Sprintf("%s/=/dhcp_subnet_free_ip/%d", c.baseURL, subnetID), nil)
if err != nil {
return "", err
}

req.SetBasicAuth(c.username, c.password)

res, err := c.client.Do(req)
if err != nil {
return "", err
}
if res.StatusCode != http.StatusOK {
return "", fmt.Errorf("error from tidyDNS server: %s", res.Status)
}

var freeIP dhcpFreeIP
err = json.NewDecoder(res.Body).Decode(&freeIP)
if err != nil {
return "", err
}

return freeIP.Data.IPAddress, nil
}

func (c *tidyDNSClient) CreateDHCPInterface(ctx context.Context, createInfo CreateInfo) (int, error) {
data := url.Values{
"subnet_id": {strconv.Itoa(createInfo.SubnetID)},
"zone_id": {strconv.Itoa(createInfo.ZoneID)},
"name": {createInfo.InterfaceName},
"destination": {createInfo.InterfaceIP},
"location_id": {strconv.Itoa(createInfo.LocationID)},
}

var checkstring string = fmt.Sprintf("Key (destination)=(%s) already exists", createInfo.InterfaceIP)

req, err := http.NewRequestWithContext(ctx, "POST", fmt.Sprintf("%s/=/dhcp_interface//new", c.baseURL), strings.NewReader(data.Encode()))
if err != nil {
return 0, err
}
req.SetBasicAuth(c.username, c.password)
req.Header.Set("Content-Type", "application/x-www-form-urlencoded")

res, _ := c.client.Do(req)

if res.StatusCode != http.StatusOK {
bodyBytes, err := io.ReadAll(res.Body)
bodyString := string(bodyBytes)
if err != nil {
return 0, err
}
if strings.Contains(bodyString, checkstring) {
return 1, fmt.Errorf("try again")
}
return 0, fmt.Errorf("error from tidyDNS server: %s", res.Status)
}

var createResp interfaceCreate
err = json.NewDecoder(res.Body).Decode(&createResp)
if err != nil {
return 0, err
}

return createResp.ID, nil
}

func (c *tidyDNSClient) ReadDHCPInterface(ctx context.Context, interfaceID int) (*InterfaceInfo, error) {
req, err := http.NewRequestWithContext(ctx, "GET", fmt.Sprintf("%s/=/dhcp_interface/?id=%d", c.baseURL, interfaceID), nil)
if err != nil {
return nil, err
}

req.SetBasicAuth(c.username, c.password)

res, err := c.client.Do(req)
if err != nil {
return nil, err
}
if res.StatusCode != http.StatusOK {
return nil, fmt.Errorf("error from tidyDNS server: %s", res.Status)
}

var interfaceRead interfaceRead
err = json.NewDecoder(res.Body).Decode(&interfaceRead)
if err != nil {
return nil, err
}

return &InterfaceInfo{
InterfaceIP: interfaceRead.Destination,
Interfacename: interfaceRead.Name,
}, nil
Comment on lines +239 to +248
Copy link

@hatrx hatrx Nov 27, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any reason for creating a whole new interfaceRead type when you are just copying the data to InterfaceInfo? Seems like you only need one or the other

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree it might be superfluous, but I would prefer not breaking backward compatibility by changing the interface.
Also I think it might be wise to separate the internals from the interface we expose to the users of the go api.

}

func (c *tidyDNSClient) UpdateDHCPInterfaceName(ctx context.Context, interfaceID int, interfaceName string) (int, error) {
data := url.Values{
"name": {interfaceName},
}

req, err := http.NewRequestWithContext(ctx, "POST", fmt.Sprintf("%s/=/dhcp_interface//%d", c.baseURL, interfaceID), strings.NewReader(data.Encode()))
if err != nil {
return 0, err
}
req.SetBasicAuth(c.username, c.password)
req.Header.Set("Content-Type", "application/x-www-form-urlencoded")

res, err := c.client.Do(req)
if err != nil {
return 0, err
}
if res.StatusCode != http.StatusOK {
return 0, fmt.Errorf("error from tidyDNS server: %s", res.Status)
}

var createResp interfaceCreate
err = json.NewDecoder(res.Body).Decode(&createResp)
if err != nil {
return 0, err
}

return createResp.ID, nil
}

func (c *tidyDNSClient) DeleteDHCPInterface(ctx context.Context, interfaceID int) error {
req, err := http.NewRequestWithContext(ctx, "DELETE", fmt.Sprintf("%s/=/dhcp_interface/%d", c.baseURL, interfaceID), nil)
if err != nil {
return err
}

req.SetBasicAuth(c.username, c.password)

res, err := c.client.Do(req)
if err != nil {
return err
}
if res.StatusCode != http.StatusOK {
return fmt.Errorf("error from tidyDNS server: %s", res.Status)
}

return nil
}

func (c *tidyDNSClient) ListZones(ctx context.Context) ([]*ZoneInfo, error) {
var zones []zoneInfo
err := c.getData(ctx, fmt.Sprintf("%s/=/zone?type=json", c.baseURL), &zones)
Expand Down Expand Up @@ -150,10 +340,12 @@ func (c *tidyDNSClient) CreateRecord(ctx context.Context, zoneID int, info Recor

res, err := c.client.Do(req)
if res != nil {
defer res.Body.Close()
defer func(Body io.ReadCloser) {
_ = Body.Close()
}(res.Body)
}

if err != nil {
if err != nil || res == nil {
return 0, err
}
if res.StatusCode != http.StatusOK {
Expand All @@ -169,10 +361,12 @@ func (c *tidyDNSClient) CreateRecord(ctx context.Context, zoneID int, info Recor

res, err = c.client.Do(req)
if res != nil {
defer res.Body.Close()
defer func(Body io.ReadCloser) {
_ = Body.Close()
}(res.Body)
}

if err != nil {
if err != nil || res == nil {
return 0, err
}
if res.StatusCode != http.StatusOK {
Expand Down Expand Up @@ -212,10 +406,12 @@ func (c *tidyDNSClient) UpdateRecord(ctx context.Context, zoneID int, recordID i

res, err := c.client.Do(req)
if res != nil {
defer res.Body.Close()
defer func(Body io.ReadCloser) {
_ = Body.Close()
}(res.Body)
}

if err != nil {
if err != nil || res == nil {
return err
}
if res.StatusCode != http.StatusOK {
Expand Down Expand Up @@ -300,10 +496,12 @@ func (c *tidyDNSClient) DeleteRecord(ctx context.Context, zoneID int, recordID i

res, err := c.client.Do(req)
if res != nil {
defer res.Body.Close()
defer func(Body io.ReadCloser) {
_ = Body.Close()
}(res.Body)
}

if err != nil {
if err != nil || res == nil {
return err
}
if res.StatusCode != http.StatusOK {
Expand All @@ -323,10 +521,12 @@ func (c *tidyDNSClient) getData(ctx context.Context, url string, value interface

res, err := c.client.Do(req)
if res != nil {
defer res.Body.Close()
defer func(Body io.ReadCloser) {
_ = Body.Close()
}(res.Body)
}

if err != nil {
if err != nil || res == nil {
return err
}
if res.StatusCode != http.StatusOK {
Expand Down
Loading