support for PHP 8.4

nette · Jun 18, 2024 · 560b43a · 560b43a
1 parent 99976d6
commit 560b43a
Show file tree

Hide file tree

Showing 7 changed files with 11 additions and 10 deletions.
diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
@@ -8,7 +8,7 @@ jobs:
         strategy:
             matrix:
                 os: [ubuntu-latest, windows-latest]
-                php: ['8.0', '8.1', '8.2', '8.3']
+                php: ['8.0', '8.1', '8.2', '8.3', '8.4']
 
             fail-fast: false
 

diff --git a/composer.json b/composer.json
@@ -15,7 +15,7 @@
 		}
 	],
 	"require": {
-		"php": "8.0 - 8.3"
+		"php": "8.0 - 8.4"
 	},
 	"require-dev": {
 		"nette/tester": "^2.5",

diff --git a/readme.md b/readme.md
@@ -41,7 +41,7 @@ The recommended way to install is via Composer:
 composer require nette/utils
 ```
 
-Nette Utils 4.0 is compatible with PHP 8.0 to 8.3.
+Nette Utils 4.0 is compatible with PHP 8.0 to 8.4.
 
  <!---->
 

diff --git a/src/Utils/Callback.php b/src/Utils/Callback.php
@@ -94,7 +94,7 @@ public static function toReflection($callable): \ReflectionMethod|\ReflectionFun
 		}
 
 		if (is_string($callable) && str_contains($callable, '::')) {
-			return new ReflectionMethod($callable);
+			return new ReflectionMethod(...explode('::', $callable, 2));
 		} elseif (is_array($callable)) {
 			return new ReflectionMethod($callable[0], $callable[1]);
 		} elseif (is_object($callable) && !$callable instanceof \Closure) {

diff --git a/src/Utils/Reflection.php b/src/Utils/Reflection.php
@@ -100,7 +100,7 @@ public static function getMethodDeclaringMethod(\ReflectionMethod $method): \Ref
 
 		$hash = [$method->getFileName(), $method->getStartLine(), $method->getEndLine()];
 		if (($alias = $decl->getTraitAliases()[$method->name] ?? null)
-			&& ($m = new \ReflectionMethod($alias))
+			&& ($m = new \ReflectionMethod(...explode('::', $alias, 2)))
 			&& $hash === [$m->getFileName(), $m->getStartLine(), $m->getEndLine()]
 		) {
 			return self::getMethodDeclaringMethod($m);
@@ -125,7 +125,7 @@ public static function getMethodDeclaringMethod(\ReflectionMethod $method): \Ref
 	public static function areCommentsAvailable(): bool
 	{
 		static $res;
-		return $res ?? $res = (bool) (new \ReflectionMethod(__METHOD__))->getDocComment();
+		return $res ?? $res = (bool) (new \ReflectionMethod(self::class, __FUNCTION__))->getDocComment();
 	}
 
 

diff --git a/tests/Utils/Callback.closure.phpt b/tests/Utils/Callback.closure.phpt
@@ -87,7 +87,7 @@ class TestChild extends Test
 function getName($ref)
 {
 	if ($ref instanceof ReflectionFunction) {
-		return $ref->getName();
+		return $ref->getShortName();
 	} elseif ($ref instanceof ReflectionMethod) {
 		return $ref->getDeclaringClass()->getName() . '::' . $ref->getName();
 	}
@@ -121,9 +121,9 @@ test('closure', function () {
 	Assert::same($closure, Closure::fromCallable($closure));
 	Assert::same($closure, Callback::unwrap($closure));
 	Assert::same('{closure}', Callback::toString($closure));
-	Assert::same('{closure}', getName(Callback::toReflection($closure)));
-	Assert::same('{closure}', Closure::fromCallable($closure)(...[&$res]));
-	Assert::same('{closure}', $res);
+	Assert::match('{closure%a?%}', getName(Callback::toReflection($closure)));
+	Assert::match('{closure%a?%}', Closure::fromCallable($closure)(...[&$res]));
+	Assert::match('{closure%a?%}', $res);
 });
 
 

diff --git a/tests/Utils/Reflection.toString.phpt b/tests/Utils/Reflection.toString.phpt
@@ -34,3 +34,4 @@ Assert::same('$param in Foo::method()', Reflection::toString(new ReflectionParam
 Assert::same('Foo::$var', Reflection::toString(new ReflectionProperty('Foo', 'var')));
 Assert::same('func()', Reflection::toString(new ReflectionFunction('func')));
 Assert::same('$param in func()', Reflection::toString(new ReflectionParameter('func', 'param')));
+Assert::same('$param in {closure}()', Reflection::toString((new ReflectionFunction(function($param){}))->getParameters()[0]));