Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor endorse popover #54

Open
volkyeth opened this issue Dec 6, 2024 · 0 comments
Open

Refactor endorse popover #54

volkyeth opened this issue Dec 6, 2024 · 0 comments

Comments

@volkyeth
Copy link
Member

volkyeth commented Dec 6, 2024

The current approach of the endorse popover is using the Radix UI popover.
It seems to keep track and update positioning even when the popover is closed. That's causing react render stack overflows (Maximum update depth exceeded) when I use force layouts on #11 and cards are moving a lot and overlapping

We should try https://github.com/floating-ui/floating-ui which seems to support more optimizations

Ideally there would be a single EndorsePopover element which we would render outside the card (like it is with e.g. NegateDialog and MakePointDialog) and then dynamically anchor to the button used to open it

@volkyeth volkyeth added this to Kanban Dec 6, 2024
@volkyeth volkyeth moved this to Todo in Kanban Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

1 participant