You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The current approach of the endorse popover is using the Radix UI popover.
It seems to keep track and update positioning even when the popover is closed. That's causing react render stack overflows (Maximum update depth exceeded) when I use force layouts on #11 and cards are moving a lot and overlapping
Ideally there would be a single EndorsePopover element which we would render outside the card (like it is with e.g. NegateDialog and MakePointDialog) and then dynamically anchor to the button used to open it
The text was updated successfully, but these errors were encountered:
The current approach of the endorse popover is using the Radix UI popover.
It seems to keep track and update positioning even when the popover is closed. That's causing react render stack overflows (Maximum update depth exceeded) when I use force layouts on #11 and cards are moving a lot and overlapping
We should try https://github.com/floating-ui/floating-ui which seems to support more optimizations
Ideally there would be a single EndorsePopover element which we would render outside the card (like it is with e.g. NegateDialog and MakePointDialog) and then dynamically anchor to the button used to open it
The text was updated successfully, but these errors were encountered: