Refactor (most) components to use props instead of direct store access #582
Labels
flag:discuss
Flag issue that needs to be discussed before it can be implemented.
_flag:stale
[BOT ONLY] Flag issue that hasn't been updated in a while and needs to be triaged again
refactor
Simplifying or restructuring existing code or documentation.
someday
Not a priority right now, but we want to keep this around to think or discuss more.
This is a bit of a 180 on what we had discussed previously - giving component direct store access instead of pushing props around. I think the reasoning behind that decision was good: make it super clear who has responsibility for the global state.
However, this came with two downsides:
I suggest we keep what's good about the current solution, but slowly remove / refactor what's bad about it.
The good (what we keep):
The bad (what we want to change):
Instead we should:
Given our very strong test suite, we should be able to approach this refactor step by step, e.g. by changing pages and components we are already working on for some other reason.
The text was updated successfully, but these errors were encountered: