Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the digest to work with the latest imaging processing status file #158

Open
michellewang opened this issue Nov 11, 2024 · 2 comments · May be fixed by #166
Open

Update the digest to work with the latest imaging processing status file #158

michellewang opened this issue Nov 11, 2024 · 2 comments · May be fixed by #166
Assignees
Labels
schema Updating input schema for improved generalizability or usability

Comments

@michellewang
Copy link
Collaborator

nipoppy track now produces files like this

participant_id	bids_participant_id	session_id	bids_session_id	pipeline_name	pipeline_version	pipeline_step	status
001	sub-001	A	ses-A	pipeline1	0.1.0	step1	FAIL
001	sub-001	A	ses-A	pipeline1	0.1.0	step2	INCOMPLETE
001	sub-001	A	ses-A	pipeline1	0.2.0	default	SUCCESS
001	sub-001	A	ses-A	pipeline2	1.0.0	default	SUCCESS
001	sub-001	B	ses-B	pipeline2	1.0.0	default	UNAVAILABLE
002	sub-002	A	ses-A	pipeline1	0.2.0	default	SUCCESS
002	sub-002	A	ses-A	pipeline2	1.0.0	default	SUCCESS
002	sub-002	B	ses-B	pipeline2	1.0.0	default	SUCCESS

which is no longer compatible with the format expected by the digest.

Not sure how much work it would be to do the update but it would be nice to have it working with the latest Nipoppy format. Though I guess that will break things for NIMHANS if they are using the digest right now @nikhil153?

@surchs surchs added flag:discuss Flag issue that needs to be discussed before it can be implemented. flag:schedule Flag issue that should go on the roadmap or backlog. labels Dec 2, 2024
@alyssadai alyssadai moved this to Backlog in Neurobagel Dec 2, 2024
@alyssadai alyssadai removed the flag:schedule Flag issue that should go on the roadmap or backlog. label Dec 2, 2024
@alyssadai alyssadai moved this from Backlog to Implement - Active in Neurobagel Dec 4, 2024
@alyssadai alyssadai removed the flag:discuss Flag issue that needs to be discussed before it can be implemented. label Dec 4, 2024
@alyssadai alyssadai self-assigned this Dec 4, 2024
@alyssadai alyssadai added the schema Updating input schema for improved generalizability or usability label Dec 9, 2024
@surchs surchs moved this from Implement - Active to Implement - Track in Neurobagel Dec 11, 2024
@surchs
Copy link
Contributor

surchs commented Dec 11, 2024

On hold while Alyssa is away

@alyssadai alyssadai moved this from Implement - Track to Implement - Active in Neurobagel Dec 13, 2024
@alyssadai
Copy link
Collaborator

Note: This issue (PR #166) also requires regenerating and updating the internal paths to the 'pre-loaded' QPN imaging and phenotypic digests, previously expected to be at a path nipoppy-qpn/nipoppy/digest in the nipoppy-qpn repo. Now that this repo is deprecated and split into qpn_workflows and qpn_analysis, we should choose a location (maybe qpn_workflows/digest or qpn_workflows/tabular/digest?) to store the two digest files.

The QPN imaging and phenotypic digests should be regenerated to align with the latest digest schemas (which now should be aligned with the latest Nipoppy schema), including:

@alyssadai alyssadai moved this from Implement - Active to Implement - Done in Neurobagel Dec 13, 2024
@surchs surchs moved this from Implement - Done to Review - Active in Neurobagel Dec 14, 2024
@alyssadai alyssadai moved this from Review - Active to Implement - Track in Neurobagel Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
schema Updating input schema for improved generalizability or usability
Projects
Status: Implement - Track
Development

Successfully merging a pull request may close this issue.

3 participants