Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider removing column categories in digest schemas #163

Open
alyssadai opened this issue Dec 13, 2024 · 1 comment
Open

Consider removing column categories in digest schemas #163

alyssadai opened this issue Dec 13, 2024 · 1 comment

Comments

@alyssadai
Copy link
Collaborator

alyssadai commented Dec 13, 2024

The differentiation of GLOBAL_COLUMNS vs. PIPELINE_STATUS_COLUMNS (or ASSESSMENT_SPECIFIC_COLUMNS in the phenotypic schema) is partially an artifact from when different pipeline steps were represented as separate columns. These categories may not serve much of a purpose now that we have pipeline_step and status.

One option would be to remove these top-level keys entirely from the schemas. Alternatively, we could explore other categories, if there is another grouping that would be useful for digest file generation.

@michellewang
Copy link
Collaborator

I think it makes sense to remove the top-level keys now that all column names are fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

2 participants