Skip to content
This repository has been archived by the owner on Mar 9, 2024. It is now read-only.

Switch to requesting available terms for queryable variables from linked API(s) #261

Closed
4 tasks done
alyssadai opened this issue Nov 6, 2023 · 4 comments · Fixed by #308
Closed
4 tasks done

Switch to requesting available terms for queryable variables from linked API(s) #261

alyssadai opened this issue Nov 6, 2023 · 4 comments · Fixed by #308
Assignees
@rmanaem
Labels
feat:add The first minimal viable change that implements a new functionality. type:feature Effort to deliver new features, feature changes & improvements

Comments

@alyssadai
Copy link
Contributor

alyssadai commented Nov 6, 2023 •
edited by rmanaem
Loading

Now that neurobagel/federation-api#12 is done, the f-API has an endpoint to get available terms from all available n-APIs.

We should now

  • Fetch the available terms for diagnosis and assessment tool from the new f-API endpoint
  • Decide at what stage of the lifecycle we should make the request
  • Remove the old hardcoded diagnosis and assessment options.
  • Provide a nice error message (e.g. https://bootstrap-vue.org/docs/components/toast) if either or both of these requests fail and we get zero terms back from the f-API
@alyssadai alyssadai added feat:add The first minimal viable change that implements a new functionality. type:feature Effort to deliver new features, feature changes & improvements flag:schedule Flag issue that should go on the roadmap or backlog. labels Nov 6, 2023
@surchs surchs added this to Neurobagel Nov 6, 2023
@alyssadai alyssadai removed the flag:schedule Flag issue that should go on the roadmap or backlog. label Nov 6, 2023
@alyssadai alyssadai changed the title Switch to requesting available terms for queryable variables from node API(s) Switch to requesting available terms for queryable variables from linked API(s) Nov 7, 2023
@alyssadai alyssadai moved this to Backlog in Neurobagel Nov 7, 2023
@alyssadai alyssadai mentioned this issue Nov 7, 2023
Closed
@surchs
Copy link
Contributor

surchs commented Nov 13, 2023

comes after neurobagel/federation-api#12

@surchs surchs moved this from Backlog to Specify - Active in Neurobagel Nov 21, 2023
@surchs
Copy link
Contributor

surchs commented Nov 21, 2023

@rmanaem mind taking a look and seeing if there is anything else to be added

@rmanaem
Copy link
Collaborator

rmanaem commented Nov 21, 2023 •
edited
Loading

Looks good to go.
We can start working on it once neurobagel/api#211 is done.

@surchs surchs moved this from Specify - Active to Specify - Done in Neurobagel Nov 21, 2023
@surchs surchs added the flag:blocked flag that issue is blocked by at least one other issue and cannot be completed until then. label Nov 23, 2023
@surchs surchs moved this from Specify - Done to Implement - Track in Neurobagel Nov 23, 2023
@rmanaem rmanaem moved this from Implement - Track to Implement - Active in Neurobagel Nov 27, 2023
@rmanaem rmanaem removed the flag:blocked flag that issue is blocked by at least one other issue and cannot be completed until then. label Nov 27, 2023
@rmanaem rmanaem self-assigned this Nov 27, 2023
@rmanaem
Copy link
Collaborator

rmanaem commented Nov 28, 2023

Blocked by #305

@rmanaem rmanaem moved this from Implement - Active to Implement - Track in Neurobagel Nov 28, 2023
@rmanaem rmanaem moved this from Implement - Track to Implement - Active in Neurobagel Nov 29, 2023
@rmanaem rmanaem mentioned this issue Nov 29, 2023
Merged
6 tasks
@rmanaem rmanaem moved this from Implement - Active to Implement - Done in Neurobagel Nov 29, 2023
@surchs surchs moved this from Implement - Done to Review - Active in Neurobagel Nov 30, 2023
@github-project-automation github-project-automation bot moved this from Review - Active to Review - Done in Neurobagel Dec 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rmanaem rmanaem

Labels
feat:add The first minimal viable change that implements a new functionality. type:feature Effort to deliver new features, feature changes & improvements
Projects
Neurobagel
Archived in project
Milestone
No milestone
3 participants
@surchs @alyssadai @rmanaem