Skip to content
This repository has been archived by the owner on Mar 9, 2024. It is now read-only.

Clarify query parameter names #285

Closed
1 task done
alyssadai opened this issue Nov 16, 2023 · 3 comments · Fixed by #335
Closed
1 task done

Clarify query parameter names #285

alyssadai opened this issue Nov 16, 2023 · 3 comments · Fixed by #335
Assignees
Labels
feat:add The first minimal viable change that implements a new functionality. feat:improve Incremental, user facing improvements of an existing feature.

Comments

@alyssadai
Copy link
Contributor

alyssadai commented Nov 16, 2023

While we are still only handling non-session-level phenotypic information, we should update the names of the query parameters in the UI accordingly so there is no confusion about which timepoint users are querying for.

These include:
"Min/max age" -> "Min/max age at baseline"
"Diagnosis" -> "Diagnosis at baseline"
"Minimum number of sessions" -> "Minimum number of imaging sessions"

TODO

  • have on-hover tooltip for each query parameter
@alyssadai alyssadai added documentation Changes only affect the documentation flag:schedule Flag issue that should go on the roadmap or backlog. labels Nov 16, 2023
@rmanaem rmanaem moved this to Backlog in Neurobagel Nov 21, 2023
@rmanaem rmanaem added feat:add The first minimal viable change that implements a new functionality. feat:improve Incremental, user facing improvements of an existing feature. and removed flag:schedule Flag issue that should go on the roadmap or backlog. documentation Changes only affect the documentation labels Nov 21, 2023
@surchs surchs moved this from Backlog to Specify - Active in Neurobagel Dec 4, 2023
@surchs surchs moved this from Specify - Active to Specify - Done in Neurobagel Dec 6, 2023
@rmanaem rmanaem moved this from Specify - Done to Implement - Active in Neurobagel Dec 13, 2023
@rmanaem rmanaem self-assigned this Dec 13, 2023
@rmanaem
Copy link
Collaborator

rmanaem commented Dec 13, 2023

@neurobagel/dev There is one issue with adding a tooltip for diagnosis. Since we already have a tooltip for healthy control and because the healthy control checkbox is implemented as part of the diagnosis categorical component, when we hover over the healthy control checkbox both tooltips get rendered

Image

Are we okay with merging the two?

@rmanaem
Copy link
Collaborator

rmanaem commented Dec 15, 2023

@surchs Could you add a drawing of what you mentioned during stand-up?

@surchs
Copy link
Contributor

surchs commented Dec 15, 2023

something like this:
image

  1. add horizontal dividers to visually differentiate two new sections (pheno and imaging)
  2. move all pheno things to pheno section, and all imaging things to imaging section (modality and # sessions)
  3. add one disclaimer at the top of the pheno session that all variables are taken at baseline session

@rmanaem rmanaem moved this from Implement - Active to Implement - Done in Neurobagel Dec 18, 2023
@surchs surchs moved this from Implement - Done to Review - Active in Neurobagel Dec 18, 2023
@github-project-automation github-project-automation bot moved this from Review - Active to Review - Done in Neurobagel Dec 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feat:add The first minimal viable change that implements a new functionality. feat:improve Incremental, user facing improvements of an existing feature.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants