-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore E203 in flake8 #149
Comments
This will also let us merge neurobagel/bagel-cli#297 |
One weird aspect is that I haven't been able to reproduce these false positives from flake8 locally. I.e. they only seem to happen as part of the pre-commit CI run |
Can we close this since neurobagel/bagel-cli#300 is merged? |
Ignore rule needs to be added to all repos where pre-commit-CI is set up |
is there going to be enough overlap on the ignore rules to sync them to all (python) repos? I would assume so |
There may not be enough overlap to just sync .precomit-config across all python repos. Let's revisit this issue when the E203 error pops up again. Likely at that point we would address it more generally by making the python repo setup consistent across our repos. That would be more of a maintenance milestone probably |
flake8 causes false positives of E203 (https://www.flake8rules.com/rules/E203.html) in certain cases
Since black handles this correctly (afaict), let's ignore rule 203 and get the linters to calm down a bit
The text was updated successfully, but these errors were encountered: