Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change TSV column names Num{Phenotypic,Imaging}Sessions to NumMatching{Phenotypic,Imaging}Sessions #136

Closed
alyssadai opened this issue Apr 18, 2024 · 2 comments · Fixed by #357
Closed

Change TSV column names Num{Phenotypic,Imaging}Sessions to NumMatching{Phenotypic,Imaging}Sessions #136

alyssadai opened this issue Apr 18, 2024 · 2 comments · Fixed by #357
Assignees
@rmanaem
Labels
good first issue Good issue for a new contributor. PR welcome Issue that is not an internal priority, but external PRs to address it are welcome. quick fix Minimal planning and/or implementation work required. released This issue/pull request has been released.

Comments

@alyssadai
Copy link
Contributor

alyssadai commented Apr 18, 2024 •
edited
Loading

The counts reflect the number of session matching the query, not the total per subject, so we should update the column names in the results TSVs to avoid confusion (the API results also include "matching" in the corresponding field names)
@alyssadai alyssadai changed the title Change column names Num{Phenotypic,Imaging}Sessions to NumMatching{Phenotypic,Imaging}Sessions Change TSV column names Num{Phenotypic,Imaging}Sessions to NumMatching{Phenotypic,Imaging}Sessions Apr 18, 2024
@alyssadai alyssadai added flag:schedule Flag issue that should go on the roadmap or backlog. good first issue Good issue for a new contributor. PR welcome Issue that is not an internal priority, but external PRs to address it are welcome. quick fix Minimal planning and/or implementation work required. and removed flag:schedule Flag issue that should go on the roadmap or backlog. labels Apr 18, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 4, 2024

We want to keep our issues up to date and active. This issue hasn't seen any activity in the last 75 days.
We have applied the _flag:stale label to indicate that this issue should be reviewed again.
When you review, please reread the spec and then apply one of these three options:

  • prioritize: apply the flag:schedule label to suggest moving this issue into the backlog now
  • close: if the issue is no longer relevant, explain why (give others a chance to reply) and then close.
  • archive: sometimes an issue has important information or ideas but we won't work on it soon. In this case
    apply the someday label to show that this won't be prioritized. The stalebot will ignore issues with this
    label in the future. Use sparingly!

@github-actions github-actions bot added the _flag:stale [BOT ONLY] Flag issue that hasn't been updated in a while and needs to be triaged again label Jul 4, 2024
@alyssadai alyssadai moved this to Implement - Done in Neurobagel Nov 18, 2024
@alyssadai alyssadai mentioned this issue Nov 18, 2024
Merged
8 tasks
@github-actions github-actions bot removed the _flag:stale [BOT ONLY] Flag issue that hasn't been updated in a while and needs to be triaged again label Nov 20, 2024
@github-project-automation github-project-automation bot moved this from Review - Active to Review - Done in Neurobagel Nov 21, 2024
@neurobagel-bot Neurobagel Bot
Copy link
Contributor

🚀 Issue was released in v0.7.0 🚀

@neurobagel-bot neurobagel-bot bot added the released This issue/pull request has been released. label Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rmanaem rmanaem

Labels
good first issue Good issue for a new contributor. PR welcome Issue that is not an internal priority, but external PRs to address it are welcome. quick fix Minimal planning and/or implementation work required. released This issue/pull request has been released.
Projects
Neurobagel
Status: Review - Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ENH] Modified the result tables for humans and machines neurobagel/query-tool
2 participants
@alyssadai @rmanaem