Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AVAILABLE PIPELINES hover on results card looks a little strange when there's no pipeline data #334

Closed
alyssadai opened this issue Oct 29, 2024 · 4 comments · Fixed by #336
Closed

AVAILABLE PIPELINES hover on results card looks a little strange when there's no pipeline data #334

alyssadai opened this issue Oct 29, 2024 · 4 comments · Fixed by #336
Assignees
@rmanaem
Labels
flag:discuss Flag issue that needs to be discussed before it can be implemented. released This issue/pull request has been released.

Comments

@alyssadai
Copy link
Contributor

When a matching dataset for a query doesn't have any info on available pipelines, the hover text appears as a little blank bubble, which unfortunately looks like a UI bug rather than something intentional.

Image

Suggestions:

  • Maybe we could display the word "None" in the bubble when there's no pipeline info? Or just disable the hover in those cases?
@alyssadai alyssadai added flag:discuss Flag issue that needs to be discussed before it can be implemented. flag:schedule Flag issue that should go on the roadmap or backlog. labels Oct 29, 2024
@surchs
Copy link
Contributor

surchs commented Oct 29, 2024

I'd vote to hide or grey out the button if no pipelines are available

@surchs surchs moved this to Backlog in Neurobagel Oct 29, 2024
@surchs surchs removed the flag:schedule Flag issue that should go on the roadmap or backlog. label Oct 29, 2024
@rmanaem
Copy link
Contributor

rmanaem commented Oct 29, 2024

I could also modify the text to say no pipelines available on the button

@surchs
Copy link
Contributor

surchs commented Oct 29, 2024

how about just no pipelines and available pipelines?

@rmanaem rmanaem self-assigned this Oct 30, 2024
@rmanaem rmanaem moved this from Backlog to Implement - Active in Neurobagel Oct 30, 2024
@rmanaem rmanaem mentioned this issue Oct 31, 2024
Merged
7 tasks
@github-project-automation github-project-automation bot moved this from Review - Active to Review - Done in Neurobagel Oct 31, 2024
@neurobagel-bot Neurobagel Bot
Copy link
Contributor

neurobagel-bot bot commented Nov 5, 2024

🚀 Issue was released in v0.6.0 🚀

@neurobagel-bot neurobagel-bot bot added the released This issue/pull request has been released. label Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rmanaem rmanaem

Labels
flag:discuss Flag issue that needs to be discussed before it can be implemented. released This issue/pull request has been released.
Projects
Neurobagel
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[FIX] Implemented "no pipelines" button neurobagel/query-tool
3 participants
@surchs @alyssadai @rmanaem