Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the how to get data modal #367

Closed
3 tasks done
rmanaem opened this issue Nov 21, 2024 · 2 comments · Fixed by #370
Closed
3 tasks done

Update the how to get data modal #367

rmanaem opened this issue Nov 21, 2024 · 2 comments · Fixed by #370
Assignees
Labels
released This issue/pull request has been released.

Comments

@rmanaem
Copy link
Contributor

rmanaem commented Nov 21, 2024

Once neurobagel/dataget#9 is addressed:

  • Update the instructions for how to get data
  • Release query tool
  • Mention that users have to manually "CTRL+C" to exit otherwise the container will hang (edit: no longer needed now that we have an echo statement to signal script completion)
@rmanaem rmanaem self-assigned this Nov 21, 2024
@rmanaem rmanaem moved this to Implement - Active in Neurobagel Nov 21, 2024
@alyssadai
Copy link
Contributor

alyssadai commented Nov 21, 2024

Hey @rmanaem, upon further reflection I realized that my suggestion to rename "How to get data" to "How to get data from datalad" might not be a good idea, since I forgot BIC users still need to view the modal for how to download the machine-readable TSV to feed to the dedicated BIC symlink script.

How about instead, having two sections in the modal, one of which is more generic:

Query results for programmatic use/download
  <any general info on the `cohort-participant-machine-results.tsv`>
Downloading matching subjects from DataLad datasets
  <info about using dataget>

(or something similar for section names)

For the BIC then, we could refer them to just the first section assuming they want to download the PD data. Meanwhile, for any users who want to download query results from DataLad datasets/OpenNeuro, both sections would be relevant.

@github-project-automation github-project-automation bot moved this from Implement - Done to Review - Done in Neurobagel Nov 25, 2024
Copy link
Contributor

🚀 Issue was released in v0.7.0 🚀

@neurobagel-bot neurobagel-bot bot added the released This issue/pull request has been released. label Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released This issue/pull request has been released.
Projects
Status: Review - Done
Development

Successfully merging a pull request may close this issue.

2 participants