Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prettier preflight option causes warnings #81

Closed
surchs opened this issue Mar 9, 2024 · 2 comments · Fixed by #87
Closed

Prettier preflight option causes warnings #81

surchs opened this issue Mar 9, 2024 · 2 comments · Fixed by #87
Assignees
Labels
quick fix Minimal planning and/or implementation work required. released This issue/pull request has been released.

Comments

@surchs
Copy link
Contributor

surchs commented Mar 9, 2024

We have this line in our prettier config that was added during the tailwind install
https://github.com/neurobagel/query-tool/blame/99fc5c019054aff221280b37ab1a09886721134a/.prettierrc.json#L9-L11

When I run prettier locally, I get a bunch of:

[warn] Ignored unknown option { corePlugins: { preflight: false } }

Warnings. They don't do anything, but they look ugly - and this could be prettier 🥁

I also can't find this corePlugins section referenced anywhere in the docs for tailwind or the tailwind prettier plugin: https://github.com/tailwindlabs/prettier-plugin-tailwindcss?tab=readme-ov-file#installation

So I think we could just remove this

@rmanaem
Copy link
Contributor

rmanaem commented Mar 13, 2024

I also can't find this corePlugins section referenced anywhere in the docs for tailwind or the tailwind prettier plugin: https://github.com/tailwindlabs/prettier-plugin-tailwindcss?tab=readme-ov-file#installation

This is from the mui docs, see https://mui.com/material-ui/integrations/interoperability/#tailwind-css and we may have copy pasted this from the tailwind config during setup

So I think we could just remove this

I believe we can remove it from prettierrc.json

@rmanaem rmanaem self-assigned this Mar 13, 2024
@rmanaem rmanaem moved this to Implement - Active in Neurobagel Mar 13, 2024
@rmanaem rmanaem added the quick fix Minimal planning and/or implementation work required. label Mar 13, 2024
@rmanaem rmanaem moved this from Implement - Active to Implement - Done in Neurobagel Mar 13, 2024
@surchs surchs moved this from Implement - Done to Review - Active in Neurobagel Mar 17, 2024
@github-project-automation github-project-automation bot moved this from Review - Active to Review - Done in Neurobagel Mar 18, 2024
@surchs
Copy link
Contributor Author

surchs commented Apr 11, 2024

🚀 Issue was released in v0.2.0 🚀

@surchs surchs added the released This issue/pull request has been released. label Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
quick fix Minimal planning and/or implementation work required. released This issue/pull request has been released.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants