Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: clean bindings #ntrn-410 #166

Merged
merged 35 commits into from
Oct 31, 2024
Merged

feat: clean bindings #ntrn-410 #166

merged 35 commits into from
Oct 31, 2024

Conversation

NeverHappened
Copy link
Contributor

@NeverHappened NeverHappened commented Oct 9, 2024 •
edited
Loading

Remove bindings and related code from neutron-sdk ,neutron-dev-contracts and integration tests
https://hadronlabs.atlassian.net/browse/NTRN-410

PR's:

  • neutron-sdk removes bindings and prototypes that are in neutron-std. Use all needed types from neutron-std;
  • neutron-dev-contracts replace bindings with grpc
  • neutron-integration-tests removed binding tests, adapter other things to new dev-contracts changed inteface
  • neutron some queries and tx's that were used in bindings were missing. Added them.
  • neutron-std regen proto types

@NeverHappened NeverHappened self-assigned this Oct 9, 2024
This was referenced Oct 16, 2024
Merged
Merged
Merged
Merged
@NeverHappened NeverHappened marked this pull request as ready for review October 16, 2024 14:02
pr0n00gler
pr0n00gler requested changes Oct 21, 2024
View reviewed changes
packages/neutron-sdk/src/lib.rs Outdated
@@ -3,22 +3,18 @@
// #![forbid(unsafe_code)]
#![warn(trivial_casts, trivial_numeric_casts, unused_import_braces)]

// TODO: can we get it from other place? or move NEUTRON_COMMIT to other place
// TODO: do we need NEUTROND_VERSION?
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need this constant anymore, since we are not building proto files here now

sotnikov-s
sotnikov-s requested changes Oct 27, 2024
View reviewed changes
Copy link
Contributor

@sotnikov-s sotnikov-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please pay utter attention to descriptions for funcs and other helpers that are in neutron-sdk package. this is crucial to have them up-to-date, comprehensive and well-written

Makefile Show resolved Hide resolved
contracts/neutron_interchain_queries/src/contract.rs Outdated Show resolved Hide resolved
contracts/neutron_interchain_queries/src/testing/mock_querier.rs Outdated Show resolved Hide resolved
contracts/neutron_interchain_queries/src/testing/tests.rs Outdated Show resolved Hide resolved
contracts/neutron_interchain_txs/src/contract.rs Outdated Show resolved Hide resolved
packages/neutron-sdk/src/interchain_queries/mod.rs Outdated Show resolved Hide resolved
packages/neutron-sdk/src/interchain_queries/v045/register_queries.rs Show resolved Hide resolved
packages/neutron-sdk/src/interchain_txs/helpers.rs Show resolved Hide resolved
contracts/neutron_interchain_txs/src/contract.rs Outdated Show resolved Hide resolved
contracts/neutron_interchain_txs/src/contract.rs Outdated Show resolved Hide resolved
@NeverHappened
Copy link
Contributor Author

https://github.com/neutron-org/neutron-tests/actions/runs/11563490362

sotnikov-s
sotnikov-s previously approved these changes Oct 29, 2024
View reviewed changes
sotnikov-s
sotnikov-s previously approved these changes Oct 30, 2024
View reviewed changes
pr0n00gler
pr0n00gler previously approved these changes Oct 31, 2024
View reviewed changes
@NeverHappened NeverHappened dismissed stale reviews from pr0n00gler and sotnikov-s via 5935e3f October 31, 2024 10:35
@pr0n00gler pr0n00gler merged commit b83c182 into main Oct 31, 2024
8 checks passed
@NeverHappened NeverHappened deleted the feat/clean-bindings branch October 31, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pr0n00gler pr0n00gler pr0n00gler approved these changes

@sotnikov-s sotnikov-s sotnikov-s left review comments

Assignees

@NeverHappened NeverHappened

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NeverHappened @pr0n00gler @sotnikov-s