Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support eslint #50

Open
nevinera opened this issue May 10, 2023 · 1 comment
Open

support eslint #50

nevinera opened this issue May 10, 2023 · 1 comment
Labels
tool-support Supporting a new tool or use-case

Comments

@nevinera
Copy link
Owner

The most popular linting framework for frontend code - seems valuable to support :-)

@nevinera nevinera added the tool-support Supporting a new tool or use-case label May 25, 2023
@nevinera nevinera assigned nevinera and unassigned nevinera May 28, 2023
@JonathanWThom JonathanWThom self-assigned this Jun 3, 2023
@nevinera
Copy link
Owner Author

nevinera commented Jun 4, 2023

I poked at this one a bit already @JonathanWThom, but the problem I ran into is that the way you run eslint isn't consistent. Most projects seem to specify a bunch of the config for the tool by creating one or more package.json script entries that runs eslint with additional arguments supplied, and they name them just whatever they feel like.

I think we might need to hold off on this until we have a way to let users supply their own command (and/or base_command`) for certain tools through the config file, like

eslint:
  base_command: ".node_modules/bin/eslint --foo --bar --config .myconfig.json"
  filter_messages: true
  changed_files: true

I ticketed that as its own issue here just now, if you'd like to take a crack at that first :-)

@JonathanWThom JonathanWThom removed their assignment Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tool-support Supporting a new tool or use-case
Projects
None yet
Development

No branches or pull requests

2 participants