Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tolerate misbehaving desks #412

Open
DavidVentura opened this issue Feb 13, 2024 · 2 comments
Open

Tolerate misbehaving desks #412

DavidVentura opened this issue Feb 13, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@DavidVentura
Copy link

Hi
I was getting really erratic behavior from this tool, so I added debug info on the _bytes_to_meters_and_speed function and the 2nd byte was always stuck at 0xff, basically reporting my desk was at ~7meters:

$ idasen height
['0x17', '0xff', '0x0', '0x0']
7.150 meters

After lowering my desk all the way to zero, it started reporting proper values and idasen starting behaving well again.
In the meantime, I had asked it to save my position with idasen save stand and it "corrupted" the configuration, by storing a 7m height.

I think that

  • there should be a warning by the tool if the second byte is 0xff
  • invalid heights shouldn't be saved to the config
@newAM
Copy link
Owner

newAM commented Mar 5, 2024

For future reference do you have the stock controller or a modded one?

@newAM newAM added the enhancement New feature or request label Mar 5, 2024
@DavidVentura
Copy link
Author

stock

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants